Add BoTorch kernel preset, which uses dimensions-scaled prior #483
+12,246
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hrovatin
requested review from
Scienfitz,
AdrianSosic and
AVHopp
as code owners
Otherwise get the below error when running benchmark actions: `Missing optional dependency 'openpyxl'.`
Hrovatin
force-pushed
the
feature/botorch_kernel_preset
branch
from
51851d8 to
50f75e1
Compare
Rebase onto benchmark branch
Hrovatin
force-pushed
the
feature/botorch_kernel_preset
branch
from
50f75e1 to
1b46aa6
Compare
AdrianSosic
reviewed
Feb 28, 2025
There was a problem hiding this comment.
Hi @Hrovatin, just two comments upfront, to save us some work later:
- The point of the botorch preset should not be to cook up the same prior logic again in our code but to make sure that the GPs are simply called without any additional arguments. The noticable difference is that the latter automatically i) avoids any potential bugs from our end plus ii) will automatically adapt when botorch makes changes
- The preset should not only affect the kernel priors but all priors. This is also automatically fulfilled by not passing anything to the constructor.
- I suggest you split up the PR into two, one that brings the preset (which we want to have anyway, regardless of benchmark performance) and another that adds the benchmarks. Otherwise, this will be a ton of code to review
Cheers 🙃
There was a problem hiding this comment.
Ah then I strongly misunderstood the aim - we should then align during the meeting next week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can stay a draft until it is validated that the performance improves with this preset and that we even want to use it.