- Fixed "responce" typo and other typos in doc and comments #299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for this awesome library! It is working perfectly on both ESP8266 and ESP32 cores, so probably it deserves a rename.
However the "responce" typo just let me down a bit, especially since it is quite prominent since exposed in the API.
What about a rename? I know that this will change the API, so probably you will be interested in maintaining the backward compatibility.
Please let me know if you want to do that, eventually with the usage of
__attribute__((deprecated))
in order to raise warnings at compile time.A whole next level change would be to rename the methods to drop the master/slave naming in favor of client/server (see here], but I noticed there is always something going on, even if is not super-clear to me (it looks inverted in the RTU interface?):
Thanks!
L