Feat/caching #207
Draft
Feat/caching #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Uacias
commented
May 23, 2024
Uacias
commented
- observed wallets are live
- names of wallets are live
- balances of each token per wallet are live
added 6 commits
May 18, 2024 10:15
Fix isExecutable type from boolean to bool. Add the file to script so it is set up on init.
- Cache for all observed wallets of user (little fix needed because of edge) - Cache names of observed wallets - Cache balances of tokens per wallet
Quantity of each token now is converted from Wei.
neotheprogramist
requested changes
May 29, 2024
Rename selectedWalletFromContext to selectedWalletDetails in SelectedWalletDetails component for readability. Move cleanup to the top of useVisibleTasks. Rm unnecessary return statement from TokenRowWallets component. Modify surql files table definitions to SCHEMAFULL from SCHEMALESS.
Add total portfolio value fn, to calculate latest balance of every observed wallet per user. Add get exact tick dates function, do get dates for selected period eg. day, week, month, year.
…ully covered ticks scenarios.
Add fetching all data for charts, time reduced to ~1s, can be optimized by creating queries then batch query to db. Fix dashboard charts bugs. Add deleting wallet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.