Wgpu resources are no longer wrapped in Arc (since they are now Clone)
#5612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Wumpf
commented
Jan 16, 2025
| @@ -402,6 +402,7 @@ impl<'a, State> Harness<'a, State> { | |||
| /// | |||
| /// # Errors | |||
| /// Returns an error if the rendering fails. | |||
| #[cfg(any(feature = "wgpu", feature = "snapshot"))] | |||
There was a problem hiding this comment.
bacon was unhappy before. understandable!
|
Preview available at https://egui-pr-preview.github.io/pr/5612-reduce-wgpu-arc |
emilk
approved these changes
Jan 16, 2025
bircni
approved these changes
Jan 17, 2025
bircni
suggested changes
Jan 18, 2025
Co-authored-by: Nicolas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wgpu 24 makes most of its interface
Clone. Which means we no longer have to wrap everything inArc! \o/