Add initial lift translation as a prop #594
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reason
Adding this because I noticed in latets version that on computer my mouse can trigger a loop when it hovers at the bottom of a toast container.
This will cause the toasts to expand, lift up above where mouse is hovering, lose focus, collapse, and repeat.
I wasn't exactly sure why the initial lift value was hardcoded, so rather than remove it, just added a way to set that value (in my case to 0).
Guidance
I don't contribute to a lot of OSS, so if there anything minor that's wrong with this, please feel free to let me know.