Account for possible utf-8 bom in toc files #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore the bom, and also check for all possible ##Dependencies aliases - see https://warcraft.wiki.gg/wiki/TOC_format#Dependencies Signed-off-by: Allen Faure <[email protected]>
emmericp
requested changes
Apr 12, 2024
| local key, value = line:match("^##%s*([^:%s]+)%s*:%s*(.-)%s*$") | ||
| ---@diagnostic disable-next-line: err-esc | ||
| local _, key, value = line:match("^(\xef?\xbb?\xbf?)##%s*([^:%s]+)%s*:%s*(.-)%s*$") | ||
| print(_, key, value) |
| @@ -6,10 +6,12 @@ function mod:InjectDependency(lines, dep) | |||
| local foundDependencyEntry = false | |||
| local foundPerfyMetadata = false | |||
| for i, line in ipairs(lines) do | |||
| local key, value = line:match("^##%s*([^:%s]+)%s*:%s*(.-)%s*$") | |||
| ---@diagnostic disable-next-line: err-esc | |||
| local _, key, value = line:match("^(\xef?\xbb?\xbf?)##%s*([^:%s]+)%s*:%s*(.-)%s*$") | |||
There was a problem hiding this comment.
the bom itself is unused, can you remove the capture for it?
There was a problem hiding this comment.
Since lua patterns do not have non-capturing capture groups, the next best thing might be this?
local key, value = select(2, line:match("^(\xef?\xbb?\xbf?)##%s*([^:%s]+)%s*:%s*(.-)%s*$"))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altoholic (it's always the dinosaur addons) has one in Altoholic.toc:
