added gitlab support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderanger
reviewed
Jun 30, 2021
There was a problem hiding this comment.
Overall looks good.
You also need to add a block of code here https://github.com/argoproj-labs/applicationset/blob/master/pkg/generators/scm_provider.go#L62-L71 to stitch things together between the config struct and generator struct(s).
api/v1alpha1/applicationset_types.go
Outdated
| type SCMProviderGeneratorGitlab struct { | ||
| // GitHub org to scan. Required. | ||
| Group string `json:"group"` | ||
| // The GitHub API URL to talk to. If blank, use https://api.github.com/. |
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| // func checkRateLimit(t *testing.T, err error) { |
There was a problem hiding this comment.
Guessing you commented this because it would collide with the impl from github? Could rename that checkGithubRateLimit and this checkGitlabRateLimit since they might not use the same error messages? But "rate limit exceeded" is generic enough it might work for both by accident :D
Co-authored-by: Noah Kantrowitz <[email protected]>
…pplicationset into gitlab-provider
…pplicationset into gitlab-provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.