fix: add missing x-ua-compatible to form_post and dag input

see panva#1052
emramir · Jul 21, 2021 · f773669 · f773669
1 parent caea00a
commit f773669
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/lib/helpers/defaults.js b/lib/helpers/defaults.js
@@ -80,6 +80,7 @@ async function userCodeInputSource(ctx, form, out, err) {
   }
   ctx.body = `<!DOCTYPE html>
     <head>
+      <meta http-equiv="X-UA-Compatible" content="IE=edge">
       <meta charset="utf-8">
       <title>Sign-in</title>
       <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
@@ -111,10 +112,10 @@ async function userCodeConfirmSource(ctx, form, client, deviceInfo, userCode) {
   } = ctx.oidc.client;
   ctx.body = `<!DOCTYPE html>
     <head>
+      <meta http-equiv="X-UA-Compatible" content="IE=edge">
       <meta charset="utf-8">
       <title>Device Login Confirmation</title>
       <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
-      <meta http-equiv="x-ua-compatible" content="ie=edge">
       <style>
         @import url(https://fonts.googleapis.com/css?family=Roboto:400,100);.help,h1,h1+p{text-align:center}h1,h1+p{font-weight:100}body{font-family:Roboto,sans-serif;margin-top:25px;margin-bottom:25px}.container{padding:0 40px 10px;width:274px;background-color:#f7f7f7;margin:0 auto 10px;border-radius:2px;box-shadow:0 2px 2px rgba(0,0,0,.3);overflow:hidden}h1{font-size:2.3em}button[autofocus]{width:100%;display:block;margin-bottom:10px;position:relative;font-size:14px;font-family:Arial,sans-serif;font-weight:700;height:36px;padding:0 8px;border:0;color:#fff;text-shadow:0 1px rgba(0,0,0,.1);background-color:#4d90fe;cursor:pointer}button[autofocus]:hover{border:0;text-shadow:0 1px rgba(0,0,0,.3);background-color:#357ae8}button[name=abort]{background:0 0!important;border:none;padding:0!important;font:inherit;cursor:pointer}a,button[name=abort]{text-decoration:none;color:#666;font-weight:400;display:inline-block;opacity:.6}.help{width:100%;font-size:12px}code{font-size:2em}
       </style>
@@ -148,10 +149,10 @@ async function successSource(ctx) {
   } = ctx.oidc.client;
   ctx.body = `<!DOCTYPE html>
     <head>
+      <meta http-equiv="X-UA-Compatible" content="IE=edge">
       <meta charset="utf-8">
       <title>Sign-in Success</title>
       <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
-      <meta http-equiv="x-ua-compatible" content="ie=edge">
       <style>
         @import url(https://fonts.googleapis.com/css?family=Roboto:400,100);h1,h1+p{font-weight:100;text-align:center}body{font-family:Roboto,sans-serif;margin-top:25px;margin-bottom:25px}.container{padding:0 40px 10px;width:274px;background-color:#F7F7F7;margin:0 auto 10px;border-radius:2px;box-shadow:0 2px 2px rgba(0,0,0,.3);overflow:hidden}h1{font-size:2.3em}
       </style>
@@ -355,10 +356,10 @@ async function postLogoutSuccessSource(ctx) {
   const display = clientName || clientId;
   ctx.body = `<!DOCTYPE html>
     <head>
+      <meta http-equiv="X-UA-Compatible" content="IE=edge">
       <meta charset="utf-8">
       <title>Sign-out Success</title>
       <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
-      <meta http-equiv="x-ua-compatible" content="ie=edge">
       <style>
         @import url(https://fonts.googleapis.com/css?family=Roboto:400,100);h1,h1+p{font-weight:100;text-align:center}body{font-family:Roboto,sans-serif;margin-top:25px;margin-bottom:25px}.container{padding:0 40px 10px;width:274px;background-color:#F7F7F7;margin:0 auto 10px;border-radius:2px;box-shadow:0 2px 2px rgba(0,0,0,.3);overflow:hidden}h1{font-size:2.3em}
       </style>
@@ -379,10 +380,10 @@ async function logoutSource(ctx, form) {
   shouldChange('features.rpInitiatedLogout.logoutSource', 'customize the look of the logout page');
   ctx.body = `<!DOCTYPE html>
     <head>
+      <meta http-equiv="X-UA-Compatible" content="IE=edge">
       <meta charset="utf-8">
       <title>Logout Request</title>
       <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
-      <meta http-equiv="x-ua-compatible" content="ie=edge">
       <style>
         @import url(https://fonts.googleapis.com/css?family=Roboto:400,100);button,h1{text-align:center}h1{font-weight:100;font-size:1.3em}body{font-family:Roboto,sans-serif;margin-top:25px;margin-bottom:25px}.container{padding:0 40px 10px;width:274px;background-color:#F7F7F7;margin:0 auto 10px;border-radius:2px;box-shadow:0 2px 2px rgba(0,0,0,.3);overflow:hidden}button{font-size:14px;font-family:Arial,sans-serif;font-weight:700;height:36px;padding:0 8px;width:100%;display:block;margin-bottom:10px;position:relative;border:0;color:#fff;text-shadow:0 1px rgba(0,0,0,.1);background-color:#4d90fe;cursor:pointer}button:hover{border:0;text-shadow:0 1px rgba(0,0,0,.3);background-color:#357ae8}
       </style>
@@ -403,10 +404,10 @@ async function renderError(ctx, out, error) {
   ctx.type = 'html';
   ctx.body = `<!DOCTYPE html>
     <head>
+      <meta http-equiv="X-UA-Compatible" content="IE=edge">
       <meta charset="utf-8">
       <title>oops! something went wrong</title>
       <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
-      <meta http-equiv="x-ua-compatible" content="ie=edge">
       <style>
         @import url(https://fonts.googleapis.com/css?family=Roboto:400,100);h1{font-weight:100;text-align:center;font-size:2.3em}body{font-family:Roboto,sans-serif;margin-top:25px;margin-bottom:25px}.container{padding:0 40px 10px;width:274px;background-color:#F7F7F7;margin:0 auto 10px;border-radius:2px;box-shadow:0 2px 2px rgba(0,0,0,.3);overflow:hidden}pre{white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word;margin:0 0 0 1em;text-indent:-1em}
       </style>

diff --git a/lib/response_modes/form_post.js b/lib/response_modes/form_post.js
@@ -16,6 +16,7 @@ module.exports = function formPost(ctx, action, inputs) {
 
   ctx.body = `<!DOCTYPE html>
 <head>
+  <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <title>Submitting Callback</title>
   <script>${pushInlineSha(ctx, `
     document.addEventListener('DOMContentLoaded', function () { document.forms[0].submit() });

diff --git a/lib/response_modes/web_message.js b/lib/response_modes/web_message.js
@@ -26,6 +26,7 @@ module.exports = function webMessage(ctx, redirectUri, response) {
 
   ctx.body = `<!DOCTYPE html>
 <head>
+  <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <title>Web Message Response</title>
 </head>
 <body>

diff --git a/lib/views/layout.js b/lib/views/layout.js
@@ -1,9 +1,9 @@
 module.exports = `<!DOCTYPE html>
 <html >
   <head>
+    <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <meta charset="utf-8">
     <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
-    <meta http-equiv="x-ua-compatible" content="ie=edge">
     <title>Sign-in</title>
     <style>
       @import url(https://fonts.googleapis.com/css?family=Roboto:400,100);
-Original file line number
+Diff line change
@@ Expand Up @@
       ctx.body = `<!DOCTYPE html>
     <head>
+      <meta http-equiv="X-UA-Compatible" content="IE=edge">
       <title>Web Message Response</title>
     </head>
     <body>
@@ Expand Down @@