Fix linter warnings

ship/connection_test.go

@@ -290,5 +290,4 @@ func (s *ConnectionSuite) Test_HandshakeTimer() {
 	assert.Equal(s.T(), model.CmiStateServerWait, s.sut.getState())
 	assert.Equal(s.T(), timeoutTimerTypeWaitForReady, s.sut.getHandshakeTimerType())
 	assert.Equal(s.T(), true, s.sut.getHandshakeTimerRunning())
-
 }

ship/helper_test.go

@@ -21,7 +21,6 @@ func TestJsonFromEEBUSJson(t *testing.T) {
 
 // The PMCP device mistakenly adds an `0x00` byte at the end of many messages. Test if this is handled correctly
 func TestJsonFromEEBUSJsonTrailingZeros(t *testing.T) {
-
 	bytes := []byte(`{"datagram":[{"header":[{"specificationVersion":"1.2.0"},{"addressSource":[{"device":"d:_i:3210_EVSE"},{"entity":[1,1]},{"feature":6}]},{"addressDestination":[{"device":"d:_i:3210_HEMS"},{"entity":[1]},{"feature":1}]},{"msgCounter":194},{"msgCounterReference":4890},{"cmdClassifier":"reply"}]},{"payload":[{"cmd":[[{"deviceClassificationManufacturerData":[{"deviceName":""},{"deviceCode":""},{"brandName":""},{"powerSource":"mains3Phase"}]}]]}]}]}`)
 	bytes = append(bytes, 0x00)
 
@@ -57,7 +56,7 @@ func TestShipJsonIntoEEBUSJson(t *testing.T) {
 	// TODO: move this test into connection_test using "transformSpineDataIntoShipJson()"
 	spineMsg, err := JsonIntoEEBUSJson([]byte(spineTest))
 	if err != nil {
-		t.Errorf(err.Error())
+		t.Error(err.Error())
 	}
 	payload := json.RawMessage([]byte(spineMsg))
 
@@ -72,7 +71,7 @@ func TestShipJsonIntoEEBUSJson(t *testing.T) {
 
 	msg, err := json.Marshal(shipMessage)
 	if err != nil {
-		t.Errorf(err.Error())
+		t.Error(err.Error())
 	}
 
 	json, err := JsonIntoEEBUSJson(msg)

ship/hs_access.go

@@ -70,7 +70,6 @@ func (c *ShipConnection) handshakeAccessMethods_Request(message []byte) {
 
 			c.infoProvider.ReportServiceShipID(c.remoteSKI, c.remoteShipID)
 		}
-
 	} else {
 		c.endHandshakeWithError(fmt.Errorf("access methods: invalid response: %s", dataString))
 		return

ship/hs_init.go

@@ -60,11 +60,11 @@ func (c *ShipConnection) handshakeInit_cmiStateEvaluate(message []byte) bool {
 	msgType, data := c.parseMessage(message, false)
 
 	if msgType != model.MsgTypeInit {
-		c.endHandshakeWithError(fmt.Errorf("Invalid SHIP MessageType, expected 0 and got %s" + string(msgType)))
+		c.endHandshakeWithError(fmt.Errorf("Invalid SHIP MessageType, expected 0 and got %s", string(msgType)))
 		return false
 	}
 	if len(data) > 0 && data[0] != byte(0) {
-		c.endHandshakeWithError(fmt.Errorf("Invalid SHIP MessageValue, expected 0 and got %s" + string(data)))
+		c.endHandshakeWithError(fmt.Errorf("Invalid SHIP MessageValue, expected 0 and got %s", string(data)))
 		return false
 	}
 

ship/hs_prot.go

@@ -127,7 +127,7 @@ func (c *ShipConnection) handshakeProtocol_smeProtHStateClientListenChoice(messa
 		abort = true
 	}
 
-	if msgHandshake.Formats.Format == nil || len(msgHandshake.Formats.Format) == 0 {
+	if len(msgHandshake.Formats.Format) == 0 {
 		logging.Log().Debug("format is missing")
 		abort = true
 	}