Update register remote service API #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `RegisterRemoteSKI` api call with a 2nd argument to provide the SHIP-ID if known. If provided (as a non empty string), upon SHIP handshake it will check the reported SHIP-ID from the remote service, and if it differs, will close the connection. The SHIP-ID is also made available via mDNS, and therefor should be known at all times. The implementation of `ServiceShipIDUpdate` of `HubReaderInterface` is called to report the SHIP-ID, if it wasn’t known yet.
DerAndereAndi
added
enhancement
DerAndereAndi
added a commit
to enbility/eebus-go
that referenced
this pull request
Dec 24, 2024
Change `RegisterRemoteSKI` api call with a 2nd argument to provide the SHIP-ID if known. If provided (as a non empty string), upon SHIP handshake it will check the reported SHIP-ID from the remote service, and if it differs, will close the connection. The SHIP-ID is also made available via mDNS, and therefor should be known at all times. Requires enbility/ship-go#46
|
@sthelen-enqs on SHIP level the test already exists: https://github.com/enbility/ship-go/blob/dev/ship/hs_access_test.go#L158-L175 So one could think of an additional system level test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
RegisterRemoteSKIapi call with a 2nd argument to provide the SHIP-ID if known. If provided (as a non empty string), upon SHIP handshake it will check the reported SHIP-ID from the remote service, and if it differs, will close the connection. The SHIP-ID is also made available via mDNS, and therefor should be known at all times.The implementation of
ServiceShipIDUpdateofHubReaderInterfaceis called to report the SHIP-ID, if it wasn’t known yet.