Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add django 5.2a1 initial support #9634

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add django 5.2a1 initial support #9634

wants to merge 2 commits into from

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Jan 29, 2025

No description provided.

@auvipy auvipy marked this pull request as ready for review January 29, 2025 06:15
@auvipy auvipy added this to the 3.16 milestone Jan 29, 2025
@auvipy auvipy requested a review from browniebroke January 29, 2025 06:27
@auvipy auvipy changed the title add django 5.2a1 for initial testing add django 5.2a1 initial support Jan 29, 2025
@browniebroke
Copy link
Member

browniebroke commented Jan 29, 2025

Looking at the release notes the main thing as strikes me as might need extra work is the composite primary key support. Not necessarily for right now but would be nice to get it added/covered before 5.2 final is released...

Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the docs?

* Django (4.2, 5.0, 5.1)

@auvipy
Copy link
Member Author

auvipy commented Jan 29, 2025

Regarding composite primary key support, I think that is out of scope of this PR for now. Also the composite primary key based other PR like composite ForeignKey, GFK, admin support are not merged yet. So we should keep this PR lean, just to make sure current tests pass with it. And we handle the brand new features in separate PR

@browniebroke
Copy link
Member

Regarding composite primary key support, I think that is out of scope of this PR for now

Agreed

@ulgens
Copy link

ulgens commented Jan 29, 2025

And we handle the brand new features in separate PR

Does this mean the repository is open for feature contributions again?

@auvipy
Copy link
Member Author

auvipy commented Jan 29, 2025

The repo is open to new python and django core compatibility features always. Like django ORM compatibility.

Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the home page of the docs are updated, this is good for me 👍🏻

@auvipy
Copy link
Member Author

auvipy commented Jan 30, 2025

I think the page of the doc automatically builds from the readme. But I might be wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants