Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace % string formatting with f-string #2322

Closed
wants to merge 1 commit into from

Conversation

dolfinus
Copy link

@dolfinus dolfinus commented May 1, 2024

Summary

Update string % subst usage with f-string. For logging use logger.method(string, subst) instead of explicit message formatting.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@dolfinus dolfinus changed the title Replace %s formatting with f-string Replace % formatting with f-string May 1, 2024
@dolfinus dolfinus force-pushed the fix-string-format branch from 860e276 to 1eeb14b Compare May 1, 2024 11:39
@dolfinus dolfinus changed the title Replace % formatting with f-string Replace % string formatting with f-string May 1, 2024
@dolfinus dolfinus force-pushed the fix-string-format branch from 1eeb14b to 647186f Compare May 1, 2024 11:50
@baseplate-admin
Copy link
Contributor

I did a comment on a issue, i don't think this is prioritized at this moment :

@dolfinus
Copy link
Author

dolfinus commented May 6, 2024

That comment just asks "why not f-string", and then closed without any discussion or describing a reason why not.

@baseplate-admin
Copy link
Contributor

then closed without any discussion

The thing is i didn't close the comment.

describing a reason why not.

Precisely why i dont think that this formatting issue is not high priority

@dolfinus dolfinus closed this May 6, 2024
@dolfinus dolfinus deleted the fix-string-format branch May 6, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants