Idea: Pass a copy of the scope to the ASGI app to prevent headers changing to something incompatible #2573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Changes:
The asgi spec allows changing the scope. We rely on headers as list so we copy the scope to the asgi app. Otherwise we can have suddenly headers which are an (exhausted) iterator.
Discussion: #2572 .
I am not sure if this is a good solution. In lilya we copy the scope because of this issue. So please give me guidance in case it
doesn't matches your expectations.
I can only say: I investigated a sudden crash in lilya and could trace it back to my changes and the expectation that the headers are something like a list in uvicorn. No offense meant, it is just an idea how to fix the root issue.