Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate dummy symbols #107

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Disambiguate dummy symbols #107

merged 3 commits into from
Sep 27, 2024

Conversation

OndrikB
Copy link
Contributor

@OndrikB OndrikB commented Sep 17, 2024

This makes the dummy symbols diffable even if there is more than one. I am aware that this could be considered a hacky fix, but it does do its job.

@encounter
Copy link
Owner

Appreciate the PR! Looks like the formatting is failing (cargo +nightly fmt will fix)

I think I'd prefer to do this logic when we're creating the dummy symbols in symbols_by_section. Was there a specific reason you chose this approach?

@OndrikB
Copy link
Contributor Author

OndrikB commented Sep 23, 2024

The compiler I'm using creates a new .text section for every single function, so, from my reading of the code, renaming them when creating them in symbols_by_section would not make a difference.

@encounter
Copy link
Owner

More specifically, we could track the section names via HashMap in parse, then pass the unique_section_index to symbols_by_section as we go.

@encounter
Copy link
Owner

Looks great, thank you!

@encounter encounter merged commit a06382c into encounter:main Sep 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants