Password clearing #2204 (#2205)

* Password clearing #2204 * ui-tests minor change --------- Co-authored-by: sgauruseu <[email protected]> (cherry picked from commit da3f926)
enonic · Jan 9, 2025 · 1021b10 · 1021b10
1 parent b6fa6c7
commit 1021b10
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/main/resources/lib/users.js b/src/main/resources/lib/users.js
@@ -57,7 +57,7 @@ exports.update = function updateUser(params) {
 };
 
 exports.updatePwd = function (key, pwd) {
-    var password = pwd.replace(/\s/g, '');
+    const password = pwd ? pwd.replace(/\s/g, '') : null;
     try {
         authLib.changePassword({
             userKey: key,

diff --git a/src/main/resources/services/graphql/schema/mutation.js b/src/main/resources/services/graphql/schema/mutation.js
@@ -72,7 +72,7 @@ module.exports = schemaGenerator.createObjectType({
             type: graphQl.GraphQLBoolean,
             args: {
                 key: graphQl.nonNull(graphQl.GraphQLString),
-                password: graphQl.nonNull(graphQl.GraphQLString)
+                password: graphQl.GraphQLString,
             },
             resolve: function(env) {
                 return users.updatePwd(env.args.key, env.args.password);

diff --git a/testing/page_objects/browsepanel/new.principal.dialog.js b/testing/page_objects/browsepanel/new.principal.dialog.js
@@ -41,10 +41,11 @@ class NewPrincipalDialog extends Page {
 
     async waitForDialogLoaded() {
         try {
-            return await this.waitForElementDisplayed(XPATH.container, appConst.mediumTimeout);
+            await this.waitForElementDisplayed(XPATH.container, appConst.mediumTimeout);
+            await this.pause(500);
         } catch (err) {
-            await this.saveScreenshot('err_principal_dialog_load');
-            throw new Error("New Principal dialog is not loaded in: " + appConst.mediumTimeout + " ms  " + err);
+            let screenshot = await this.saveScreenshotUniqueName('err_principal_dialog_load');
+            throw new Error(`New Principal dialog is not loaded screenshot${screenshot}: ` + err);
         }
     }