fix for failed tests

enonic · Jan 23, 2025 · ba90b7c · ba90b7c
1 parent 4bcea32
commit ba90b7c
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 6 deletions.
diff --git a/testing/libs/test.utils.js b/testing/libs/test.utils.js
@@ -266,7 +266,8 @@ module.exports = {
             await this.findAndSelectItem(displayName);
             await browsePanel.waitForEditButtonEnabled();
             await browsePanel.clickOnEditButton();
-            return await roleWizard.waitForLoaded();
+            await roleWizard.waitForLoaded();
+            await roleWizard.pause(500);
         } catch (err) {
             throw new Error("Error when open the role: " + err);
         }

diff --git a/testing/page_objects/browsepanel/userbrowse.panel.js b/testing/page_objects/browsepanel/userbrowse.panel.js
@@ -198,7 +198,8 @@ class UserBrowsePanel extends Page {
 
     async waitForDeleteButtonEnabled() {
         try {
-            await this.waitForElementEnabled(this.deleteButton, appConst.mediumTimeout)
+            await this.waitForElementEnabled(this.deleteButton, appConst.mediumTimeout);
+            await this.pause(400);
         } catch (err) {
             let screenshot = await this.saveScreenshotUniqueName('err_delete_button_not_enabled');
             throw new Error(`Delete button is not enabled ! Screenshot: ${screenshot} ` + err);

diff --git a/testing/page_objects/confirmation.dialog.js b/testing/page_objects/confirmation.dialog.js
@@ -38,10 +38,13 @@ class ConfirmationDialog extends Page {
         return this.clickOnElement(this.noButton);
     }
 
-    waitForDialogLoaded() {
-        return this.waitForElementDisplayed(XPATH.container, appConst.mediumTimeout).catch(err => {
+    async waitForDialogLoaded() {
+        try {
+            return await this.waitForElementDisplayed(XPATH.container, appConst.mediumTimeout);
+        } catch (err) {
+            let screenshot = await this.saveScreenshotUniqueName('err_confirmation_dialog');
             throw new Error("Confirmation dialog was not loaded! " + err);
-        })
+        }
     }
 
     isDialogLoaded() {

diff --git a/testing/tests/role.wizard.spec.js b/testing/tests/role.wizard.spec.js
@@ -43,6 +43,7 @@ describe('Role Wizard and Statistics Panel spec', function () {
             await userBrowsePanel.clickOnNewButton();
             await roleWizard.waitForLoaded();
             await roleWizard.typeData(TEST_ROLE);
+            await roleWizard.pause(1000);
             await roleWizard.waitAndClickOnSave();
             // Verify the notification message:
             let actualMessage = await roleWizard.waitForNotificationMessage();

diff --git a/testing/tests/user.delete.spec.js b/testing/tests/user.delete.spec.js
@@ -46,6 +46,7 @@ describe("user.delete.spec:User - confirm and delete it in the wizard and in the
             await testUtils.clickOnSystemOpenUserWizard();
             await userWizard.typeData(TEST_USER);
             await userWizard.waitAndClickOnSave();
+            await userWizard.waitForNotificationMessage();
             // 2. click on Delete and confirm:
             await userWizard.clickOnDelete();
             await testUtils.confirmDelete();

diff --git a/testing/tests/wizard.toolbar.shortcut.spec.js b/testing/tests/wizard.toolbar.shortcut.spec.js
@@ -71,7 +71,7 @@ describe(`wizard.toolbar.shortcut.spec, wizard's toolbar shortcut specification`
             // 2. Group's data has been typed:
             await groupWizard.typeDisplayName(TEST_GROUP.displayName);
             await groupWizard.waitForSaveButtonEnabled();
-            await groupWizard.pause(500);
+            await groupWizard.pause(1000);
             // 3. keyboard shortcut to save button has been pressed:
             await groupWizard.hotKeySave();
             await testUtils.saveScreenshot('group_shortcut_save');