Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password must be optional for Service Account #1808 #2188

Merged
merged 10 commits into from
Jan 20, 2025
Merged

Password must be optional for Service Account #1808 #2188

merged 10 commits into from
Jan 20, 2025

Conversation

anatol-sialitski
Copy link
Contributor

No description provided.

@anatol-sialitski anatol-sialitski linked an issue Dec 19, 2024 that may be closed by this pull request
Password must be optional for Service Account #1808
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.36%. Comparing base (136f993) to head (93bf726).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2188      +/-   ##
============================================
- Coverage     57.49%   55.36%   -2.14%     
+ Complexity      210      197      -13     
============================================
  Files            55       54       -1     
  Lines           887      876      -11     
  Branches         86       85       -1     
============================================
- Hits            510      485      -25     
- Misses          331      347      +16     
+ Partials         46       44       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anatol-sialitski
Copy link
Contributor Author

@sgauruseu could you please update UI tests?

@anatol-sialitski anatol-sialitski force-pushed the issue-1808 branch 2 times, most recently from 975a63e to a3c5fab Compare December 20, 2024 14:01
@anatol-sialitski anatol-sialitski marked this pull request as ready for review January 6, 2025 17:51
@anatol-sialitski anatol-sialitski marked this pull request as draft January 10, 2025 12:13
@anatol-sialitski
Password must be optional for Service Account #1808
4b428d8 
new ui-tests for set password #2197

ui-tests for optional password issue #2189

Password must be optional for Service Account #1808

Bump version of lib-admin-ui from 5.0.0-SNAPSHOT to 5.0.0-A1

ui-tests for optional password issue #2189

Password must be optional for Service Account #1808
@anatol-sialitski anatol-sialitski marked this pull request as ready for review January 16, 2025 08:40
@anatol-sialitski anatol-sialitski requested review from ashklianko and removed request for rymsha January 16, 2025 08:40
@alansemenov alansemenov self-requested a review January 20, 2025 14:34
@alansemenov alansemenov linked an issue Jan 20, 2025 that may be closed by this pull request
Add ui-tests for Clear password button #2213
Closed
@alansemenov alansemenov linked an issue Jan 20, 2025 that may be closed by this pull request
Add ui-tests for canceling set password action #2215
Closed
@alansemenov alansemenov merged commit a7124b8 into master Jan 20, 2025
6 of 7 checks passed
@alansemenov alansemenov deleted the issue-1808 branch January 20, 2025 14:35
alansemenov pushed a commit that referenced this pull request Jan 20, 2025
@anatol-sialitski @alansemenov
Password must be optional for Service Account #1808 (#2188)
45155c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alansemenov alansemenov alansemenov approved these changes

@ashklianko ashklianko Awaiting requested review from ashklianko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@anatol-sialitski @alansemenov