Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1500 move datafetcher to lib react4xp #1535

Merged
merged 24 commits into from
Dec 13, 2024

Conversation

ComLock
Copy link
Contributor

@ComLock ComLock commented Dec 10, 2024

Needs changes after enonic/npm-react-components#77 is released in beta

@ComLock ComLock self-assigned this Dec 10, 2024
@ComLock ComLock linked an issue Dec 10, 2024 that may be closed by this pull request
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.05%. Comparing base (0d95a05) to head (1439526).
Report is 26 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1535       +/-   ##
===========================================
- Coverage   64.55%   54.05%   -10.50%     
===========================================
  Files          12        4        -8     
  Lines         268       74      -194     
  Branches       24        5       -19     
===========================================
- Hits          173       40      -133     
+ Misses         95       34       -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alansemenov alansemenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this was done in master a while ago, so this is not strictly related to this PR, but we need to clean this up before the release:

  1. Jest is configured (jest.config, package.json, /jest/ folder etc) but doesn't seem to be used.
  2. Bun is configured but doesn't seem to be used
  3. You are using deno for tests but you don't install deno in package.json. We need to make sure tests are run on every build (npmBuild task depends on test task in build.gradle) as we do in other projects.

package.json Outdated Show resolved Hide resolved
src/main/resources/types/Request.d.ts Outdated Show resolved Hide resolved
src/main/resources/types/Component.d.ts Show resolved Hide resolved
tsup.config.ts Outdated Show resolved Hide resolved
src/main/resources/types/Response.d.ts Outdated Show resolved Hide resolved
@ComLock
Copy link
Contributor Author

ComLock commented Dec 12, 2024

I see this was done in master a while ago, so this is not strictly related to this PR, but we need to clean this up before the release:

  1. Jest is configured (jest.config, package.json, /jest/ folder etc) but doesn't seem to be used.

or write more tests using it

  1. Bun is configured but doesn't seem to be used

or write more tests using it

  1. You are using deno for tests but you don't install deno in package.json. We need to make sure tests are run on every build (npmBuild task depends on test task in build.gradle) as we do in other projects.

Deno is not a node package. Deno is a node replacement.

@alansemenov alansemenov self-requested a review December 13, 2024 09:21
@ComLock ComLock merged commit ce31e88 into master Dec 13, 2024
4 of 5 checks passed
@ComLock ComLock deleted the 1500-move-datafetcher-to-lib-react4xp branch December 13, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move dataFetcher to lib-react4xp
3 participants