-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1500 move datafetcher to lib react4xp #1535
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1535 +/- ##
===========================================
- Coverage 64.55% 54.05% -10.50%
===========================================
Files 12 4 -8
Lines 268 74 -194
Branches 24 5 -19
===========================================
- Hits 173 40 -133
+ Misses 95 34 -61 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this was done in master a while ago, so this is not strictly related to this PR, but we need to clean this up before the release:
- Jest is configured (jest.config, package.json, /jest/ folder etc) but doesn't seem to be used.
- Bun is configured but doesn't seem to be used
- You are using deno for tests but you don't install deno in package.json. We need to make sure tests are run on every build (
npmBuild
task depends ontest
task in build.gradle) as we do in other projects.
or write more tests using it
or write more tests using it
Deno is not a node package. Deno is a node replacement. |
Needs changes after enonic/npm-react-components#77 is released in beta