Refactor LocalStorage and associated hooks
#11625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
added
CI: No changelog needed
somebody1234
requested review from
PabloBuchu,
indiv0 and
MrFlashAccount
as code owners
|
@MrFlashAccount for CR |
| } = defineLocalStorageKey('localRootDirectories', { | ||
| schema: (z) => z.string().array().readonly(), | ||
| }) | ||
| export const { use: useLocalRootDirectories, useState: useLocalRootDirectoriesState } = |
There was a problem hiding this comment.
Why is it still use? Is it a hook?
There was a problem hiding this comment.
yup. it uses localStorage from the context, not sure if it's necessary tbh but i think removing the LocalStorageProvider is out of scope for this PR?
There was a problem hiding this comment.
Nowadays LocalStorage is a Singleton class, we can avoid using it from the context to make it possible to manipulate the storage state outside of the components, I think
…k when registering
…t to skip re-render
somebody1234
requested review from
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
somebody1234
force-pushed
the
wip/sb/refactor-localstorage
branch
from
7cce37e to
82e79fe
Compare
PabloBuchu
approved these changes
Dec 27, 2024
|
@MrFlashAccount might you have time to review this one soonish? |
modified: gui/.storybook/preview.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
localStorageto use functionality returned by a single function, rather than registering keys plugin-style when modules are loaded.Important Notes
None
Testing Instructions
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.