Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in DX/Compiler/CI #12158

Merged
merged 16 commits into from
Feb 12, 2025
Merged

Improvements in DX/Compiler/CI #12158

merged 16 commits into from
Feb 12, 2025

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Jan 27, 2025 •
edited
Loading

Pull Request Description

This PR:

  1. Run unit tests for changed code only
  2. Narrows scope for react compiler
  3. Lazy-load editor to speedup initial page open in dev mode.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@MrFlashAccount MrFlashAccount self-assigned this Jan 27, 2025
@MrFlashAccount MrFlashAccount added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 27, 2025
@MrFlashAccount MrFlashAccount marked this pull request as draft January 27, 2025 14:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

🧪 Storybook is successfully deployed!

📊 Dashboard:

@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/test-eslint-caches branch from 0fa4d26 to 06aa9fd Compare January 28, 2025 06:17
@MrFlashAccount MrFlashAccount changed the title Don't touch it. The PR is for investigating eslint cache issues Run only changed unit tests. Narrow compiler scope. Jan 29, 2025
@MrFlashAccount MrFlashAccount changed the title Run only changed unit tests. Narrow compiler scope. Improvements in DX/Compiler/CI Jan 29, 2025
@MrFlashAccount MrFlashAccount marked this pull request as ready for review January 29, 2025 12:45
farmaazon
farmaazon requested changes Jan 30, 2025
View reviewed changes
.github/workflows/gui-checks.yml Outdated Show resolved Hide resolved
@MrFlashAccount MrFlashAccount added the CI: Keep up to date Automatically update this PR to the latest develop. label Feb 4, 2025
@MrFlashAccount MrFlashAccount removed the CI: Keep up to date Automatically update this PR to the latest develop. label Feb 4, 2025
@MrFlashAccount MrFlashAccount added the CI: Keep up to date Automatically update this PR to the latest develop. label Feb 10, 2025
@MrFlashAccount MrFlashAccount added CI: Ready to merge This PR is eligible for automatic merge and removed CI: Keep up to date Automatically update this PR to the latest develop. labels Feb 12, 2025
somebody1234
somebody1234 reviewed Feb 12, 2025
View reviewed changes
app/gui/vite.config.ts
include: fileURLToPath(new URL('./src/dashboard/**/*.tsx', import.meta.url)),
include: [
fileURLToPath(new URL('./src/dashboard/**/*.tsx', import.meta.url)),
fileURLToPath(new URL('./src/dashboard/**/use*.ts', import.meta.url)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

somebody1234
somebody1234 reviewed Feb 12, 2025
View reviewed changes
app/gui/src/dashboard/pages/dashboard/DashboardTabPanels.tsx
@@ -61,7 +62,7 @@ export function DashboardTabPanels(props: DashboardTabPanelsProps) {
shouldForceMount: true,
className: 'flex min-h-0 grow [&[data-inert]]:hidden',
children: (
<Editor
<LazyEditor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

somebody1234
somebody1234 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cr ✅

@mergify mergify bot merged commit 8bc7025 into develop Feb 12, 2025
43 of 45 checks passed
@mergify mergify bot deleted the wip/sergeigarin/test-eslint-caches branch February 12, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farmaazon farmaazon farmaazon approved these changes

@somebody1234 somebody1234 somebody1234 approved these changes

@PabloBuchu PabloBuchu Awaiting requested review from PabloBuchu PabloBuchu is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@jdunkerley jdunkerley Awaiting requested review from jdunkerley

@hubertp hubertp Awaiting requested review from hubertp

Assignees

@MrFlashAccount MrFlashAccount

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrFlashAccount @farmaazon @somebody1234