-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix infinite recursion when calling to_text
on an Atom with lazy field
#12253
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- fixes the problem - good
- however this will prevent already computed fields to be visible
- shouldn't we differentiate between computed/not yet computed lazy field?
Done in e6242ae by introducing a new message |
That's very clever idea!
Very nice evolution approach. |
Fixes #7138
Pull Request Description
Invoking
to_text
method on an atom with a lazy field may result in an infinite recursion. This PR fixes that by recognizing a lazy field, and printing it with just~field_name
, instead of evaluating it.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.