Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for expressions #12262

Merged
merged 16 commits into from
Feb 13, 2025
Merged

Add unit tests for expressions #12262

merged 16 commits into from
Feb 13, 2025

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Feb 12, 2025

Pull Request Description

Adds java tests to the expression part of the code. Relies heavily on mocking as a way to understand how the API works.

Full end to end tests already exist at enso/test/Table_Tests/src/Common_Table_Operations/Expression_Spec.enso

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@AdRiley AdRiley changed the title Wip/adr/add expression tests Add unit tests for expressions Feb 12, 2025
@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 12, 2025
Copy link
Collaborator

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit re sbt build

build.sbt Outdated Show resolved Hide resolved
@AdRiley AdRiley merged commit fea3957 into develop Feb 13, 2025
52 of 53 checks passed
@AdRiley AdRiley deleted the wip/adr/add-expression-tests branch February 13, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants