-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use of ChacoPlotItem in attractors example #416
Conversation
In regards to #404, the example currently "works" but it is lacking safeguards so a user can easily crash things...
(At least the full application doesn't crash) Alternatively, select
Ideally we would restrict these values to non-breaking ranges. Also the latter traceback I believe is a known issue. |
@observe("active_model") | ||
def _update_plot_new_model(self, event): | ||
if event.old: | ||
self.plot.delplot(event.old.name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old active_model's name is the old title
that was used as the name for the previous plot.
I do think this naming is a little confusing, as title
is not actually used as a title... In fact, prior to this PR it was not actually used at all! I found it convenient for naming plots so they could be easily deleted when we switch models.
Note that if we do not delete the old plot when we change model, things appear to work perfectly fine initially, however if you change models a few times eventually you see the
OverflowError: Exceeded cell block limit
Abort trap: 6
crash as mentioned in another comment. Deleting old plots prevents this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #409
part of #404
This PR removes the use of
ChacoPlotItem
which has recently been removed on chaco master and will be unavailable with the next release of chaco.