Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PATCH and DELETE handling for /v3/transactions/{id} #842

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

morremeyer
Copy link
Member

This adds the ability to PATCH and DELETE transaction resources.

@morremeyer morremeyer requested a review from a team as a code owner November 16, 2023 08:23
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (4308b38) 81.47% compared to head (861ed59) 81.71%.

Files Patch % Lines
pkg/controllers/transaction_v3.go 76.78% 22 Missing and 4 partials ⚠️
pkg/controllers/match_rule.go 0.00% 1 Missing ⚠️
pkg/controllers/rename_rule.go 0.00% 1 Missing ⚠️
pkg/httperrors/errors.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   81.47%   81.71%   +0.23%     
==========================================
  Files          42       42              
  Lines        4384     4522     +138     
==========================================
+ Hits         3572     3695     +123     
- Misses        671      683      +12     
- Partials      141      144       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@morremeyer morremeyer force-pushed the feat/v3-delete-transaction branch from a717cea to 3123464 Compare November 16, 2023 08:55
This adds the ability to PATCH and DELETE transaction resources.
@morremeyer morremeyer force-pushed the feat/v3-delete-transaction branch from 3123464 to 861ed59 Compare November 16, 2023 09:05
@morremeyer morremeyer merged commit 1b2321c into main Nov 16, 2023
6 checks passed
@morremeyer morremeyer deleted the feat/v3-delete-transaction branch November 16, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant