Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Match Rules support to v3 #850

Merged
merged 1 commit into from
Nov 20, 2023
Merged

feat: add Match Rules support to v3 #850

merged 1 commit into from
Nov 20, 2023

Conversation

morremeyer
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 134 lines in your changes are missing coverage. Please review.

Comparison is base (af0fbbe) 81.32% compared to head (0962565) 81.51%.

Files Patch % Lines
pkg/controllers/match_rule_v2.go 38.70% 92 Missing and 3 partials ⚠️
pkg/controllers/match_rule_v3.go 85.00% 33 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
+ Coverage   81.32%   81.51%   +0.18%     
==========================================
  Files          42       44       +2     
  Lines        4558     4821     +263     
==========================================
+ Hits         3707     3930     +223     
- Misses        703      737      +34     
- Partials      148      154       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@morremeyer morremeyer marked this pull request as ready for review November 20, 2023 21:59
@morremeyer morremeyer requested a review from a team as a code owner November 20, 2023 21:59
@morremeyer morremeyer merged commit 4cf875f into main Nov 20, 2023
@morremeyer morremeyer deleted the feat/v3-match-rules branch November 20, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant