Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add *testing.T as first argument for createTestTransactionV3 #868

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

morremeyer
Copy link
Member

This will lead to better test failure messages and is already implemented
for all other v3 controller tests.

This will lead to better test failure messages and is already implemented
for all other v3 controller tests.
@morremeyer morremeyer requested a review from a team as a code owner December 1, 2023 16:15
@morremeyer morremeyer enabled auto-merge (squash) December 1, 2023 16:16
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcc9209) 81.12% compared to head (5c89969) 81.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #868   +/-   ##
=======================================
  Coverage   81.12%   81.12%           
=======================================
  Files          49       49           
  Lines        5626     5626           
=======================================
  Hits         4564     4564           
  Misses        881      881           
  Partials      181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@morremeyer morremeyer merged commit d7dcd75 into main Dec 1, 2023
6 checks passed
@morremeyer morremeyer deleted the test/use-testing-t-everywhere branch December 1, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant