feat: add YNAP parsing to transaction import #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morremeyer
force-pushed
the
feat/parse-transactions
branch
from
b1b4c2b to
03c9c13
Compare
morremeyer
force-pushed
the
feat/parse-transactions
branch
from
03c9c13 to
a0ea617
Compare
morremeyer
force-pushed
the
feat/parse-transactions
branch
from
a0ea617 to
e5ec03a
Compare
morremeyer
force-pushed
the
feat/parse-transactions
branch
2 times, most recently
from
ffd66b4 to
7b63389
Compare
malfynnction
reviewed
Sep 2, 2023
morremeyer
force-pushed
the
feat/parse-transactions
branch
from
7b63389 to
fd01349
Compare
morremeyer
force-pushed
the
feat/parse-transactions
branch
6 times, most recently
from
cbe1f79 to
2c14ff5
Compare
This adds YNAP parsing to transaction importing, removing the need to parse the file in the YNAP web app before uploading it to Envelope Zero. Since the jschardet dependency for ynap-parsers does not support strict mode, we need to patch its sloppiness, too. Co-Authored-By: Fynn Heintz <[email protected]> Co-Authored-By: Morre <[email protected]>
morremeyer
force-pushed
the
feat/parse-transactions
branch
from
95add52 to
45517bc
Compare
malfynnction
reviewed
Sep 3, 2023
Co-authored-by: Fynn Heintz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds YNAP parsing to transaction importing, removing the need to
parse the file in the YNAP web app before uploading it to Envelope Zero.
Obsoletes #1043.
Part of #936.