Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang: allow injecting extra data #38362

Merged
merged 1 commit into from
Feb 24, 2025
Merged

golang: allow injecting extra data #38362

merged 1 commit into from
Feb 24, 2025

Conversation

spacewander
Copy link
Contributor

Commit Message: golang: allow injecting extra data
Additional Description: This PR adds a feature that allows users to flush the data immediately when processing the data asynchronously.
Risk Level: Low
Testing: Integration test
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38362 was opened by spacewander.

see: more, trace.

@spacewander spacewander force-pushed the 0208 branch 2 times, most recently from ca98608 to a124f63 Compare February 10, 2025 03:54
@spacewander
Copy link
Contributor Author

CC @doujiang24

Copy link
Member

@doujiang24 doujiang24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@doujiang24
Copy link
Member

It's good enough to merge, thanks @mattklein123 @wbpcode

Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind approval because senior maintainer of this extension have given a LGTM. Thanks.

@wbpcode wbpcode merged commit 6c11eac into envoyproxy:main Feb 24, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants