Rewrite deploy action to handle multi-arch #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes made (TL;DR)
(fixes Add multi-arch support #245, fixes exec user process caused "exec format error" #279 and fixes Build a mult-arch image #307)
(fixes Add 4.2 tag #327 and fixes 4.0 tag should not point to 4.2 #338)
More in depth
This rewritten deploy workflow achieves supporting multiple architectures without modifications to docker-template and making use of currently available tools to cross-build for different platforms.
I've tried to keep the changes to the current setup to a minimum. I (obviously) could not try this workflow with your credentials but I've tested it with mine and it worked. Got the same repo/tag structure but for multiple (linux) architectures. See job 3951534375, it produced images and tags in the following repositories:
The changes include the use of new action 'ruby/setup-ruby' instead of the, now defunct, 'actions/setup-ruby'. See deprecation notes. This fixes the reason for the current failures on jobs like 3880108024.
Also note that current
deploy.yml
creates tags '4' and '4.0' to follow '4.2.2'. IMHO, this should be '4' and '4.2'. Happy to revert the change if it is not a bug.For this PR to work, first PR #355 needs to be merged. Otherwise all jobs fail (as expected).
I'm happy to make any changes (maybe update to 4.3?) or if you want other formatting with more space or less. Just let me know. I'm happy to elaborate on how anything in this PR works if needed as well.
Cheers