Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to appeal suspensions from within the tool #1003

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add ability to appeal suspensions from within the tool #1003

wants to merge 5 commits into from

Conversation

stwalkerster
Copy link
Member

@stwalkerster stwalkerster commented Dec 27, 2024 •
edited
Loading

This change does several things:

  • Merges the concepts of suspended and declined users into a single "deactivated" user
  • Adds a form to appeal deactivations; submission of which will move a user into the "New" state and write the message to the log
  • Adds the ability to disable the ability for a user to appeal in case of abuse
  • Hides the comments from account status changes (specifically suspension/appeals) from all but tool admins and the affected user themselves

@stwalkerster stwalkerster force-pushed the appeals branch 2 times, most recently from a4537b0 to c7051e0 Compare December 31, 2024 20:39
@stwalkerster
Fix save failure on preferences edit while not active
67c6e88 
Because suspended/declined/new users don't get the role permissions they
should normally get as an active user, no available account creation
modes are available. This means that the barrier test on the creation
mode during a preferences save throws an exception which is never caught

This should prevent the exception from being thrown.
@stwalkerster
Merge declined and suspended states for users
4468b77 
I've not seen a point in keeping these separated for a long time now.
It's easy to see if this is a new user or not from the user logs, and
restricting this to a single "not active" state makes more sense
@stwalkerster
Add appeals form for user reactivation
de46e2b
@stwalkerster
Allow tool admins to disable the ability to appeal
f6cad71
@stwalkerster stwalkerster marked this pull request as ready for review December 31, 2024 20:40
@stwalkerster
Make comments on account log entries private
e7f7584 
Tool admins, checkusers will be able to see all account logs. Users will
be able to see their own account log, even when their account is not
active.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FastLizard4 FastLizard4 Awaiting requested review from FastLizard4

@dqwiki dqwiki Awaiting requested review from dqwiki

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Review queue
Status: To Do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stwalkerster