-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version for animation with scene approach #1400
Open
anishramesan
wants to merge
294
commits into
ENYO-2174-directorapproach
Choose a base branch
from
ENYO_2174-sceneapproach
base: ENYO-2174-directorapproach
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Initial version for animation with scene approach #1400
anishramesan
wants to merge
294
commits into
ENYO-2174-directorapproach
from
ENYO_2174-sceneapproach
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Enables popping multiple views off the stack Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Rather than checking for the isManager flag which was inconsistently applied, a VM can call a private isManager method to determine if the provided view exists and is in its viewManagers hash. A consequence of this change is that VMs can only be declared within the managers[] and, when created manually, will always be considered a manager. Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
When using activate, the requestAnimationFrame caused a brief delay before the transition began which created an odd pause when releasing the drag. Using activateImmediate resolves this. Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Instead of overloading 'activate' with both views and manager and incongruently using 'deactivate' and 'dismiss' respectively for tear down, add a new 'manage' event for activation of a child ViewManager. Note that, for the time being, there is intentionally no post-transition event (like 'activated' for views) because the ViewManager's activation isn't animated in any way. Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Previously, transition completion was handled per-view so ViewLayout would fire its 'complete' event twice in most scenarios. Since ViewManager.direction to be reset when the first view transitioned, the event payload for the second view had an incorrect direction value. Furthermore, it doesn't make sense for 'complete' to fire until the entire transition is complete so it now monitors the state of both views' transition and only notifies when both are done. Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Issue: ENYO-2723 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
View activation is asynchronous (using rAF) so multiple calls to activate() in the same frame produced unexpected results and out of sync styling. For floating panels, the stack would only include the last view. For fixed panels, the direction could be incorrect if the penultimate activation was on the opposite side of the final activated view from the source view. Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Issue: ENYO-2714 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Issue: ENYO-2723 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Issue: ENYO-2714 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Issue: ENYO-2714 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Also add dragging property to distinguish between dismiss events Issue: PLAT-12048 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Fixes PLAT-12048 add dismiss event when dragging VM
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Altered ViewManager.draggable to be either Boolean or a String to support draggable, flickable, both or neither. Issue: PLAT-12457 Enyo-DCO-1.1-Signed-off-by: Ryan Duffy ([email protected])
Enyo-DCO-1.1-Signed-off-by: Anish Ramesan<[email protected]>
Bug fixing related to fixed size array used to push among intermediate points in case of custom easing. Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
Merge 2.6.0-dev into master.
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
Enyo-DCO-1.1-Signed-off-by: Anish Ramesan<[email protected]>
Add matrix related modules within matrix module and vector related module within vector module. Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
…174-sceneapproach
Enyo-DCO-1.1-Signed-off-by: Anish Ramesan<[email protected]>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
Added support for properties like translateX, rotateY, scaleZ, skewX etc. Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
With addition of various css like transform properties, e.g. translateX, rotateY etc, now we added support for multiple transform property within same animation like translateX and translateY. We also handled rotation property as it is not commutative. Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
Enyo-DCO-1.1-Signed-off-by: Ankur Mishra<[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enyo-DCO-1.1-Signed-off-by: Anish [email protected]