Skip to content

Commit

Permalink
[Breaking change]: reworked vertical padding props for ModalHeader, M…
Browse files Browse the repository at this point in the history
…odalFooter.

 Added global classes to PickerInput.
 Reworked PickerInput body ui.
 Fixed 'Filtered Table' demo
  • Loading branch information
siarhei-epam committed Mar 5, 2025
1 parent 32a09f5 commit c8b2c8f
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: qa
# Controls when the action will run.
on:
push:
branches: [ feature/4px-grid-for-uui ]
branches: [ feature/icons-for-theming ]
# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:

Expand Down
6 changes: 1 addition & 5 deletions app/src/demo/tables/filteredTable/filters.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,9 @@ export const getFilters = (): TableFiltersConfig<Person>[] => {
renderRow: (props) => (
<DataPickerRow
{ ...props }
padding="12"
size="36"
alignItems="center"
key={ props.rowKey }
renderItem={ (item: any) => <FlexRow size="36"><Badge size="24" fill="outline" indicator color={ item.name.toLowerCase() as BadgeProps['color'] } caption={ item.name } /></FlexRow> }
renderItem={ (item: any) => <FlexRow><Badge size="24" fill="outline" indicator color={ item.name.toLowerCase() as BadgeProps['color'] } caption={ item.name } /></FlexRow> }
/>
),
predicates: defaultPredicates.multiPicker,
Expand All @@ -35,8 +33,6 @@ export const getFilters = (): TableFiltersConfig<Person>[] => {
renderRow: (props, dataSourceState) => (
<DataPickerRow
{ ...props }
size="36"
padding="12"
key={ props.rowKey }
renderItem={ (item: Country, rowProps) => (
<PickerItem
Expand Down
25 changes: 25 additions & 0 deletions epam-assets/theme/variables/fresh_4px.scss
Original file line number Diff line number Diff line change
Expand Up @@ -575,4 +575,29 @@
font-weight: 700;
}
}

.uui-picker_input-body-search {
--uui-data_picker_body-search-padding: 12px;
}

.uui-picker_input-row {
margin: 0 12px;
border-radius: 4px;
}

[aria-selected='true'], [aria-selected='true'].uui-focus {
background-color: var(--uui-primary-60);

.uui-picker_input-item {
.uui-text.uui-typography-inline {
&.uui-color-primary, &.uui-color-secondary {
--uui-text: var(--uui-neutral-0);
}
}
}

.uui-picker_input-cell-select_icon {
display: none;
}
}
}
2 changes: 1 addition & 1 deletion uui/components/pickers/DataPickerCell.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export function DataPickerCell<TItem, TId>(props: DataPickerCellProps<TItem, TId
{props.renderItem(props.rowProps.value, props.rowProps)}
<FlexSpacer />
{(props.rowProps.isChildrenSelected || props.rowProps.isSelected) && (
<div className={ cx(css.iconWrapper, uuiMod.selected) }>
<div className={ cx(css.iconWrapper, 'uui-picker_input-cell-select_icon', uuiMod.selected) }>
<IconContainer
size={ settings.pickerInput.sizes.body.selectIconMap[props.size] }
icon={ SelectIcon }
Expand Down

0 comments on commit c8b2c8f

Please sign in to comment.