[Feature]: Icons for theming #2764

siarhei-epam · 2025-02-19T12:43:55Z

Description:

Added support for icons theming

Issue link:

QA notes:

# Conflicts: # uui/components/tables/DataTableRow.tsx

github-actions · 2025-02-19T12:59:41Z

Generated by: track-bundle-size
Generated at: Wed, 05 Mar 2025 20:44:13 GMT
Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.13.1 (2025-02-17)
CI Status: ok

Module	Baseline Size (v5.13.1)	Size	Diff	Within Threshold	Threshold (min - max)
templateApp	680.93	718.76	+37.83 `js:+33.33` `css:+4.5`	🆗	612.83 - 749.02
@epam/app	5790.72	5799.63	+8.91 `js:+3.35` `css:+5.56`	🆗	5211.64 - 6369.79
@epam/draft-rte	52.94	52.97	+0.02 `js:0` `css:+0.03`	🆗	47.65 - 58.24
@epam/electric	4.58	4.58	0 `js:0` `css:0`	🆗	4.12 - 5.04
@epam/promo	55.32	55.36	+0.04 `js:+0` `css:+0.04`	🆗	49.79 - 60.85
@epam/uui-extra	0.21	0.21	0 `js:0` `css:0`	🆗	0.19 - 0.23
@epam/loveship	90.46	90.51	+0.05 `js:-0.01` `css:+0.06`	🆗	81.41 - 99.51
@epam/uui-components	253.68	252.68	-1 `js:-1.03` `css:+0.03`	🆗	228.31 - 279.05
@epam/uui-core	317.54	317.54	0 `js:0` `css:0`	🆗	285.79 - 349.29
@epam/uui-db	41.63	41.63	0 `js:0` `css:0`	🆗	37.47 - 45.8
@epam/uui-docs	175.48	175.49	+0 `js:0` `css:+0`	🆗	157.94 - 193.04
@epam/uui-editor	173.66	173.67	+0.01 `js:+0` `css:+0`	🆗	156.29 - 191.03
@epam/uui-timeline	75.49	75.49	+0 `js:0` `css:+0`	🆗	67.94 - 83.04
@epam/uui	481.54	487.68	+6.14 `js:+1.5` `css:+4.64`	🆗	433.39 - 529.7

new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.13.2",
  "timestamp": "2025-03-05",
  "sizes": {
    "templateApp": {
      "css": 223731,
      "js": 512277
    },
    "@epam/app": {
      "css": 688555,
      "js": 5250258
    },
    "@epam/draft-rte": {
      "css": 9817,
      "js": 44419
    },
    "@epam/electric": {
      "css": 2275,
      "js": 2416
    },
    "@epam/promo": {
      "css": 47550,
      "js": 9134
    },
    "@epam/uui-extra": {
      "css": 0,
      "js": 213
    },
    "@epam/loveship": {
      "css": 53548,
      "js": 39135
    },
    "@epam/uui-components": {
      "css": 22693,
      "js": 236050
    },
    "@epam/uui-core": {
      "css": 0,
      "js": 325160
    },
    "@epam/uui-db": {
      "css": 0,
      "js": 42633
    },
    "@epam/uui-docs": {
      "css": 2506,
      "js": 177195
    },
    "@epam/uui-editor": {
      "css": 12757,
      "js": 165078
    },
    "@epam/uui-timeline": {
      "css": 2201,
      "js": 75105
    },
    "@epam/uui": {
      "css": 184273,
      "js": 315118
    }
  }
}

Generated by: generate-components-api
CI Status: ok

Total amount of exported types/props without JSDoc comments

	Amount
Types	320 (+18) ⚠️🆗
Props	232 (-1) 🆗

New missing comments

NOTE: It's either a new exported types/props without JSDoc, or it's an existing code from which you deleted the JSDoc comments.

Types:
- @epam/uui:AlertModsOverride
- @epam/uui:CountIndicatorModsOverride
- @epam/uui:DataPickerCellProps
- @epam/uui:DataRowAddonsModsOverride
- @epam/uui:DataTableCellModsOverride
- @epam/uui:DataTableCellProps
- @epam/uui:DataTableControlSize
- @epam/uui:DataTableHeaderCellProps
- @epam/uui:FlexRowMods
- @epam/uui:FlexRowModsOverride
- @epam/uui:IMobileDropdownWrapperProps
- @epam/uui:ModalFooterMods
- @epam/uui:ModalFooterModsOverride
- @epam/uui:ModalHeaderMods
- @epam/uui:ModalHeaderModsOverride
- @epam/uui:PartialSettings
- @epam/uui:PickerTogglerProps
- @epam/uui:StatusIndicatorModsOverride
Props:
- <empty>

app/src/data/settings_4px.ts

uui/settings.ts

app/src/data/settings_4px.ts

uui/settings.ts

AlekseyManetov · 2025-02-20T15:33:15Z

uui/settings.ts

            },
-            checkbox: {
+            itemAvatarMultilineMap: {


need to discuss

AlekseyManetov · 2025-02-20T15:34:00Z

uui/settings.ts

+                42: '42',
+                48: '48',
+            },
+            itemVerticalPaddingMap: {


need to discuss

uui/settings.ts

AlekseyManetov · 2025-02-20T15:59:41Z

uui/components/tables/DataTableCell.tsx

 import { Tooltip } from '../overlays';
 import { settings } from '../../settings';

 import './variables.scss';
 import css from './DataTableCell.module.scss';

-export function DataTableCell<TItem, TId, TCellValue>(initialProps : DataTableCellProps<TItem, TId, TCellValue> & DataTableCellMods) {
+export interface DataTableCellModsOverride {}


Need to think about this override interfaces, probably we should use here overrides from global DataTableMods interface to not force users to define overrides for such internal parts

uui/components/tables/DataTable.tsx

uui/components/tables/__tests__/__snapshots__/DataTableRow.test.tsx.snap

uui/settings.ts

…odalFooter. Added global classes to PickerInput.

…odalFooter. Added global classes to PickerInput. Reworked PickerInput body ui. Fixed 'Filtered Table' demo

# Conflicts: # app/package.json # changelog.md # draft-rte/package.json # epam-assets/package.json # epam-electric/package.json # epam-promo/package.json # extra/package.json # lerna.json # loveship/package.json # templates/uui-cra-template/package.json # test-utils/package.json # uui-build/package.json # uui-components/package.json # uui-core/package.json # uui-db/package.json # uui-docs/package.json # uui-e2e-tests/package.json # uui-editor/package.json # uui-timeline/package.json # uui/package.json

siarhei-epam added 2 commits February 19, 2025 02:01

added icons settings for theming

45336a5

fixed cyclic dependencies

6666468

siarhei-epam requested a review from AlekseyManetov February 19, 2025 12:43

siarhei-epam self-assigned this Feb 19, 2025

siarhei-epam changed the title ~~Feature/icons for theming~~ [Feature]: Icons for theming Feb 19, 2025

siarhei-epam and others added 2 commits February 19, 2025 15:49

Merge branch 'develop' into feature/icons-for-theming

1672ff6

# Conflicts: # uui/components/tables/DataTableRow.tsx

v5.13.2-rc.0

b5dacd8

updated descriptions of props

af613a6

AlekseyManetov requested changes Feb 19, 2025

View reviewed changes

AlekseyManetov requested changes Feb 20, 2025

View reviewed changes

app/src/data/settings_4px.ts Outdated Show resolved Hide resolved

uui/settings.ts Outdated Show resolved Hide resolved

uui/settings.ts Outdated Show resolved Hide resolved

AlekseyManetov requested changes Feb 20, 2025

View reviewed changes

siarhei-epam added 5 commits March 4, 2025 19:09

updated settings, part of hardcode moved to css variables

092f320

fixed AvatarStack layout

a8e5af2

fixed FlexRow vertical padding

416c1ce

Merge branch 'develop' into feature/icons-for-theming

62f9948

reverted maxHeight for mobile view (will be reworked later)

b3faccf

AlekseyManetov requested changes Mar 5, 2025

View reviewed changes

uui/components/tables/DataTable.tsx Outdated Show resolved Hide resolved

uui/components/tables/__tests__/__snapshots__/DataTableRow.test.tsx.snap Show resolved Hide resolved

uui/settings.ts Outdated Show resolved Hide resolved

siarhei-epam added 5 commits March 5, 2025 17:41

[Breaking change]: reworked vertical padding props for ModalHeader, M…

32a09f5

…odalFooter. Added global classes to PickerInput.

[Breaking change]: reworked vertical padding props for ModalHeader, M…

c8b2c8f

…odalFooter. Added global classes to PickerInput. Reworked PickerInput body ui. Fixed 'Filtered Table' demo

[PickerItem]: removed Text component to support theming

10ecfd6

updated snapshots

916cf80

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature]: Icons for theming #2764

[Feature]: Icons for theming #2764

siarhei-epam commented Feb 19, 2025

github-actions bot commented Feb 19, 2025 •

edited

Loading

AlekseyManetov Feb 20, 2025

AlekseyManetov Feb 20, 2025

AlekseyManetov Feb 20, 2025

[Feature]: Icons for theming #2764

Are you sure you want to change the base?

[Feature]: Icons for theming #2764

Conversation

siarhei-epam commented Feb 19, 2025

Description:

Issue link:

QA notes:

github-actions bot commented Feb 19, 2025 • edited Loading

AlekseyManetov Feb 20, 2025

Choose a reason for hiding this comment

AlekseyManetov Feb 20, 2025

Choose a reason for hiding this comment

AlekseyManetov Feb 20, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 19, 2025 •

edited

Loading