Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): fix text wrapping (Issue #140) #1319

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

IlyaBondar
Copy link
Collaborator

@IlyaBondar IlyaBondar commented Apr 23, 2024

Description:

fix text wrapping

Issues:

UI changes

<Please, provide Screenshots or Figma links>

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@IlyaBondar IlyaBondar added the bug Something isn't working label Apr 23, 2024
@IlyaBondar IlyaBondar self-assigned this Apr 23, 2024
@IlyaBondar
Copy link
Collaborator Author

IlyaBondar commented Apr 23, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1319.nightly-test.deltixhub.io
E2E tests status: failed

@@ -110,7 +110,7 @@ const ChatMDComponent = ({
const isOverlay = useAppSelector(SettingsSelectors.selectIsOverlay);

const mdClassNames = classnames(
'prose min-w-full dark:prose-invert prose-a:text-accent-primary prose-a:no-underline hover:prose-a:underline',
'prose min-w-full whitespace-pre-wrap dark:prose-invert prose-a:text-accent-primary prose-a:no-underline hover:prose-a:underline',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we need here is an investagation. We can't just add this style. Models can hallucinate. This can be easily reproduced by asking the model to give a nested list (e.g. with three levels of nesting).

@IlyaBondar IlyaBondar marked this pull request as draft April 23, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants