Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): remove empty chat settings (Issue #1656) #1657

Draft
wants to merge 19 commits into
base: development
Choose a base branch
from
Draft

feat(chat): remove empty chat settings (Issue #1656) #1657

wants to merge 19 commits into from

Conversation

mikitabut
Copy link
Contributor

@mikitabut mikitabut commented Jun 25, 2024 •
edited
Loading

Description:

We should highlight new conversation button on mobile
We need to get rid of empty chat settings and show them just icon of model, name of model and short description of model in this conversation

Issues:

UI changes

Design
image

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@mikitabut mikitabut changed the title feat: remove empty chat settings feat(chat): remove empty chat settings (Issue #1656) Jun 25, 2024
@mikitabut
Copy link
Contributor Author

mikitabut commented Jun 25, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1657.nightly-test.deltixhub.io
E2E tests status: failed

@irinakartun
Copy link
Contributor

irinakartun commented Jun 25, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1657.nightly-test.deltixhub.io
E2E tests status:

@irinakartun
Copy link
Contributor

irinakartun commented Jun 25, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1657.nightly-test.deltixhub.io
E2E tests status: failed

IlyaBondar
IlyaBondar reviewed Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@IlyaBondar IlyaBondar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikitabut ,
I suppose we don't need tooltip here
image
image

@irinakartun
Copy link
Contributor

irinakartun commented Jun 25, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1657.nightly-test.deltixhub.io
E2E tests status: failed

@irinakartun
Copy link
Contributor

irinakartun commented Jun 25, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1657.nightly-test.deltixhub.io
E2E tests status: failed

@irinakartun
Copy link
Contributor

irinakartun commented Jun 25, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1657.nightly-test.deltixhub.io
E2E tests status: failed

@irinakartun
Copy link
Contributor

irinakartun commented Jun 26, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1657.nightly-test.deltixhub.io
E2E tests status: failed

@irinakartun
Copy link
Contributor

irinakartun commented Jun 26, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1657.nightly-test.deltixhub.io
E2E tests status: failed

@irinakartun
Copy link
Contributor

irinakartun commented Jun 26, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1657.nightly-test.deltixhub.io
E2E tests status: success

IlyaBondar
IlyaBondar requested changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@IlyaBondar IlyaBondar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to implement switching between these two views

@IlyaBondar IlyaBondar marked this pull request as draft July 2, 2024 09:42
@dspashynskyi
Copy link
Contributor

dspashynskyi commented Jul 30, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1657.nightly-test.deltixhub.io
E2E tests status: failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyaBondar IlyaBondar IlyaBondar requested changes

@denys-kolomiitsev denys-kolomiitsev denys-kolomiitsev left review comments

@Alexander-Kezik Alexander-Kezik Awaiting requested review from Alexander-Kezik Alexander-Kezik is a code owner

@Derikyan Derikyan Awaiting requested review from Derikyan Derikyan is a code owner

@likeamike likeamike Awaiting requested review from likeamike likeamike is a code owner

@irinakartun irinakartun Awaiting requested review from irinakartun irinakartun is a code owner

@nartovm nartovm Awaiting requested review from nartovm nartovm is a code owner

@Gimir Gimir Awaiting requested review from Gimir Gimir will be requested when the pull request is marked ready for review Gimir is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikitabut @irinakartun @dspashynskyi @IlyaBondar @denys-kolomiitsev