Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlay)!: fix setting model id in overlay (Issue #2297) #2604

Open
wants to merge 10 commits into
base: development
Choose a base branch
from

Conversation

denys-kolomiitsev
Copy link
Contributor

@denys-kolomiitsev denys-kolomiitsev commented Nov 14, 2024

Description:

Fixed creation of the new conversation in overlay if modelId set in the overlay settings

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 14, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2604.nightly-test.deltixhub.io
E2E tests status: success

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 14, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2604.nightly-test.deltixhub.io
E2E tests status: failed

2 similar comments
@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 14, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2604.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 15, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2604.nightly-test.deltixhub.io
E2E tests status: failed

@denys-kolomiitsev denys-kolomiitsev changed the title fix: fix setting model id in overlay (Issue #2297) fix(overlay)!: fix setting model id in overlay (Issue #2297) Nov 15, 2024
@denys-kolomiitsev
Copy link
Contributor Author

denys-kolomiitsev commented Nov 15, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2604.nightly-test.deltixhub.io
E2E tests status: success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants