Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat): resolve dependency cycles detected by linter (Issue #3132) #3230

Open
wants to merge 26 commits into
base: development
Choose a base branch
from
Open

fix(chat): resolve dependency cycles detected by linter (Issue #3132) #3230

wants to merge 26 commits into from

Conversation

Gimir
Copy link
Contributor

@Gimir Gimir commented Feb 25, 2025

Description:

  • duplicate some utils to share-utils file to resolve deps cycles
  • resolve deps cycles in store modules

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Gimir Gimir self-assigned this Feb 25, 2025
@Gimir
Copy link
Contributor Author

Gimir commented Feb 25, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

@Gimir
Copy link
Contributor Author

Gimir commented Feb 25, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: success

@Gimir
Copy link
Contributor Author

Gimir commented Feb 25, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Feb 26, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Feb 26, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Feb 26, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

@Gimir
Copy link
Contributor Author

Gimir commented Feb 26, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: success

@Gimir
Copy link
Contributor Author

Gimir commented Feb 28, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: failed

5 similar comments
@Gimir
Copy link
Contributor Author

Gimir commented Feb 28, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Feb 28, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Feb 28, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Mar 3, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Mar 3, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Mar 3, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: failed

1 similar comment
@Gimir
Copy link
Contributor Author

Gimir commented Mar 3, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Mar 4, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Mar 5, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Mar 5, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

@Gimir
Copy link
Contributor Author

Gimir commented Mar 5, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

@Gimir
Copy link
Contributor Author

Gimir commented Mar 5, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-3230.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Mar 5, 2025 •
edited by ai-dial-actions
Loading

/deploy-review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyaBondar IlyaBondar IlyaBondar left review comments

@denys-kolomiitsev denys-kolomiitsev Awaiting requested review from denys-kolomiitsev denys-kolomiitsev is a code owner

@Alexander-Kezik Alexander-Kezik Awaiting requested review from Alexander-Kezik Alexander-Kezik is a code owner

@Derikyan Derikyan Awaiting requested review from Derikyan Derikyan is a code owner

@likeamike likeamike Awaiting requested review from likeamike likeamike is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Gimir Gimir

Labels
_priority_1 technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gimir @IlyaBondar