feat: added span name processor #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
/deploy-review
|
alekseyvdovenko
force-pushed
the
feat/issue-509
branch
2 times, most recently
from
0846028
to
7a8e5a4
Compare
alekseyvdovenko
force-pushed
the
feat/issue-509
branch
from
7a8e5a4
to
43f3f18
Compare
|
/deploy-review
|
akurnosau
previously approved these changes
Oct 9, 2024
akurnosau
reviewed
Oct 9, 2024
|
/deploy-review
|
astsiapanay
reviewed
Oct 9, 2024
|
/deploy-review
|
astsiapanay
approved these changes
Oct 9, 2024
astsiapanay
pushed a commit
that referenced
this pull request
Oct 11, 2024
Merged
astsiapanay
pushed a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Vert.x core sets "operation" (HTTP Method for client/server span kinds) as a span name:
With an opened ticket for configuring the name eclipse-vertx/vertx-tracing#59
which is a bit of non-descriptive. To be aligned with the other DIAL components, like chat, adapters, etc., which form the name as HTTP Method + HTTP Path (e.g. "POST /path/to/resource"), the idea is to introduce the span processor which will set the name the same way.