Gui improvements 28 06 2024

e2e/gui/default.conf

@@ -82,3 +82,4 @@ e2e.ui.backup.storage.path=
 e2e.ui.backup.storage.offset=
 e2e.ui.cluster.aws.ebs.type=
 e2e.ui.test.run.tag=
+e2e.ssh.cloud.region=

e2e/gui/src/test/java/com/epam/pipeline/autotests/AutopauseTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2017-2021 EPAM Systems, Inc. (https://www.epam.com/)
+ * Copyright 2017-2024 EPAM Systems, Inc. (https://www.epam.com/)
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -145,10 +145,10 @@ private void setSystemPreferences(final String maxIdleTimeout,
                         .settings()
                         .switchToPreferences()
                         .switchToSystem()
-                        .setMaxIdleTimeout(maxIdleTimeout)
                         .setIdleActionTimeout(idleActionTimeout)
                         .setIdleCpuThreshold(idleCpuThreshold)
                         .setIdleAction(idleAction)
+                        .setMaxIdleTimeout(maxIdleTimeout)
                         .saveIfNeeded()
         );
     }

e2e/gui/src/test/java/com/epam/pipeline/autotests/LaunchLimitMountsTest.java

@@ -113,6 +113,8 @@ public void setPreferences() {
     @BeforeMethod
     public void openPage() {
         open(C.ROOT_ADDRESS);
+        logoutIfNeeded();
+        loginAs(admin);
     }
 
     @AfterClass(alwaysRun = true)

e2e/gui/src/test/java/com/epam/pipeline/autotests/LaunchParametersTest.java

@@ -28,7 +28,7 @@
 import com.epam.pipeline.autotests.utils.PipelinePermission;
 import com.epam.pipeline.autotests.utils.SystemParameter;
 import com.epam.pipeline.autotests.utils.TestCase;
-
+import com.epam.pipeline.autotests.utils.Utils;
 import com.epam.pipeline.autotests.utils.listener.Cloud;
 import com.epam.pipeline.autotests.utils.listener.CloudProviderOnly;
 import org.testng.annotations.AfterClass;
@@ -95,9 +95,7 @@ public class LaunchParametersTest extends AbstractSeveralPipelineRunningTest
     private static final int DEFAULT_TERMINATE_RUN_TIMEOUT = 1;
     private static final int TEST_TERMINATE_RUN_TIMEOUT = DEFAULT_TERMINATE_RUN_TIMEOUT + 2;
     private static final String UNMOUNTING_STARTED = "Unmounting all storage mounts";
-    private static final String CLEANUP_WORNING = "Will wait for %smin to let the run stop normally. " +
-            "Otherwise it will be terminated";
-    private static final String CLEANUP_FINISH_MESSAGE = "Run #%s is still running after %smin. Terminating a node.";
+    private static final String CLEANUP_WORNING = "Marking run as finished.";
     private static final String CONSOLE = "Console";
     private static final String CLEANUP_ENVIRONMENT_TASK = "CleanupEnvironment";
     private static final String FILESYSTEM_AUTOSCALING = "FilesystemAutoscaling";
@@ -111,7 +109,7 @@ public class LaunchParametersTest extends AbstractSeveralPipelineRunningTest
     private final String registry = C.DEFAULT_REGISTRY;
     private final String group = C.DEFAULT_GROUP;
     private final String tool = C.TESTING_TOOL_NAME;
-    private final String customTag = "test_tag";
+    private final String customTag = "test_tag" + Utils.randomSuffix();
     private final String testProfile = "testprofile.q";
     private static String testInstance = "r6i.%s";
     private int[] scaling = new int[4];
@@ -200,6 +198,7 @@ public void checkSystemParametersForToolAndLaunchForm() {
                                 .cancel()
                                 .clickCustomParameter()
                                 .setName(CP_FSBROWSER_ENABLED)
+                                .close()
                                 .messageShouldAppear(PARAMETER_IS_NOT_ALLOWED_FOR_USE)
                 );
         tools()
@@ -211,6 +210,7 @@ public void checkSystemParametersForToolAndLaunchForm() {
                                 .cancel()
                                 .clickAddStringParameter()
                                 .setName(CP_FSBROWSER_ENABLED)
+                                .close()
                                 .messageShouldAppear(PARAMETER_IS_NOT_ALLOWED_FOR_USE)
                 );
     }
@@ -233,6 +233,7 @@ public void checkSystemParametersForPipelineAndDetachConfiguration() {
                             .cancel();
                     profile.clickAddStringParameter()
                             .setName(CP_FSBROWSER_ENABLED)
+                            .setValue("")
                             .messageShouldAppear(PARAMETER_IS_NOT_ALLOWED_FOR_USE)
                             .click(REMOVE_PARAMETER);
                 });
@@ -264,6 +265,7 @@ public void checkAllowedSystemParametersForToolAndLaunchForm() {
                                 .cancel()
                                 .clickCustomParameter()
                                 .setName(CP_FSBROWSER_ENABLED)
+                                .close()
                                 .messageShouldAppear(PARAMETER_IS_RESERVED)
                 );
         tools()
@@ -274,6 +276,7 @@ public void checkAllowedSystemParametersForToolAndLaunchForm() {
                                 .cancel()
                                 .clickAddStringParameter()
                                 .setName(CP_FSBROWSER_ENABLED)
+                                .close()
                                 .messageShouldAppear(NAME_IS_RESERVED)
                 );
     }
@@ -293,6 +296,7 @@ public void checkAllowedSystemParametersForPipelineAndDetachConfiguration() {
                             .cancel();
                     profile.clickAddStringParameter()
                             .setName(CP_FSBROWSER_ENABLED)
+                            .setValue("")
                             .messageShouldAppear(NAME_IS_RESERVED)
                             .click(REMOVE_PARAMETER);
                 });
@@ -443,12 +447,10 @@ public void forcibleTerminateInstancesIfJobIsStuckInUmount() {
                 .waitForLog(UNMOUNTING_STARTED)
                 .waitForTask(CLEANUP_ENVIRONMENT_TASK)
                 .clickTaskWithName(CLEANUP_ENVIRONMENT_TASK)
-                .ensure(log(), containsMessages(format(CLEANUP_WORNING, valueOf(TEST_TERMINATE_RUN_TIMEOUT))))
+                .ensure(log(), containsMessages(CLEANUP_WORNING))
                 .sleep(TEST_TERMINATE_RUN_TIMEOUT, MINUTES)
                 .refresh()
-                .shouldHaveStatus(STOPPED)
-                .ensure(log(), containsMessages(format(CLEANUP_FINISH_MESSAGE,
-                        getLastRunId(), valueOf(TEST_TERMINATE_RUN_TIMEOUT))));
+                .shouldHaveStatus(STOPPED);
     }
 
     @Test

e2e/gui/src/test/java/com/epam/pipeline/autotests/PauseResumeTest.java

@@ -179,7 +179,7 @@ public void dockerExtraMultiValidation() {
                             log
                                     .waitForPauseButton()
                                     .clickOnPauseButton()
-                                    .validateException("This operation may fail due to 'Out of disk' error")
+                                    .validateException("Free disk space is not enough")
                                     .click(button(CANCEL.name()))
                                     .shouldHaveStatus(LogAO.Status.WORKING)
                     );

e2e/gui/src/test/java/com/epam/pipeline/autotests/PipelineConfigurationTest.java

@@ -188,11 +188,11 @@ public void parametersDoesntChangeOnSwitchingConfigurations() {
             })
             .sleep(5, SECONDS)
             .editConfiguration(defaultProfile, profile ->
-                profile.refresh().ensure(byValue(firstParameter), visible)
+                profile.refresh().ensure(byValue(firstParameter), exist)
                        .ensure(byValue(firstParameterValue), visible)
             )
             .editConfiguration(anotherProfile, profile ->
-                profile.refresh().ensure(byValue(secondParameter), visible)
+                profile.refresh().ensure(byValue(secondParameter), exist)
                        .ensure(byValue(secondParameterValue), visible)
             );
     }

e2e/gui/src/test/java/com/epam/pipeline/autotests/PipelineDetailsTest.java

@@ -114,18 +114,18 @@ public void shouldCreateFileInSubfolder() {
                 .ensure(byText(pipelineFile), visible);
     }
 
-    @Test(dependsOnMethods = {"shouldCreateFileInSubfolder"})
+    @Test(enabled = false, dependsOnMethods = {"shouldCreateFileInSubfolder"})
     @TestCase(value = {"EPMCMBIBPC-344"})
     public void luigiGraphTabShouldBeValid() {
         codeTab()
                 .graphTab()
                 .ensure(CANVAS, exist);
     }
 
-    @Test(dependsOnMethods = {"luigiGraphTabShouldBeValid"})
+    @Test(dependsOnMethods = {"shouldCreateFileInSubfolder"})
     @TestCase(value = {"EPMCMBIBPC-345"})
     public void documentTabShouldBeValid() {
-        graphTab()
+        codeTab()
                 .documentsTab()
                 .ensure(UPLOAD, visible, enabled)
                 .ensure(byText("README.md"), visible)

e2e/gui/src/test/java/com/epam/pipeline/autotests/PipelineFromTemplateTest.java

@@ -56,7 +56,7 @@ public void python() {
         pipelineFromTemplateFinishesCorrectly(Template.PYTHON, "Running python pipeline");
     }
 
-    @Test
+    @Test(enabled = false)
     @TestCase("EPMCMBIBPC-542")
     public void luigi() {
         pipelineFromTemplateFinishesCorrectly(Template.LUIGI, "Running luigi pipeline");

e2e/gui/src/test/java/com/epam/pipeline/autotests/RunPipelineTest.java

@@ -15,10 +15,9 @@
  */
 package com.epam.pipeline.autotests;
 
+import com.epam.pipeline.autotests.ao.ClusterMenuAO;
 import com.epam.pipeline.autotests.ao.LogAO;
 import com.epam.pipeline.autotests.ao.NodePage;
-import static com.epam.pipeline.autotests.ao.Primitive.ESTIMATED_PRICE;
-import static com.epam.pipeline.autotests.ao.Primitive.SHOW_TIMINGS;
 import com.epam.pipeline.autotests.ao.Template;
 import com.epam.pipeline.autotests.mixins.Authorization;
 import com.epam.pipeline.autotests.utils.C;
@@ -46,11 +45,15 @@
 import static com.epam.pipeline.autotests.ao.LogAO.Status.SUCCESS;
 import static com.epam.pipeline.autotests.ao.NodePage.*;
 import static com.epam.pipeline.autotests.ao.Primitive.STATUS;
+import static com.epam.pipeline.autotests.ao.Primitive.ESTIMATED_PRICE;
+import static com.epam.pipeline.autotests.ao.Primitive.SHOW_TIMINGS;
+import static com.epam.pipeline.autotests.ao.Primitive.NEXT_PAGE;
 import static com.epam.pipeline.autotests.utils.Conditions.contains;
 import static com.epam.pipeline.autotests.utils.Conditions.*;
 import static com.epam.pipeline.autotests.utils.PipelineSelectors.*;
 import static com.epam.pipeline.autotests.utils.Utils.resourceName;
 import static com.epam.pipeline.autotests.utils.Utils.sleep;
+import static com.epam.pipeline.autotests.utils.Utils.ON_DEMAND;
 import static java.util.concurrent.TimeUnit.SECONDS;
 import static java.util.stream.Collectors.toList;
 import static java.util.stream.Collectors.toSet;
@@ -64,6 +67,8 @@ public class RunPipelineTest extends AbstractSeveralPipelineRunningTest implemen
     private final String pipeline314 = resourceName("epmcmbibpc-314");
     private final String pipeline306 = resourceName("epmcmbibpc-306");
     private final String pipeline312 = resourceName("epmcmbibpc-312");
+    private String storage1 = "runPipelineTestStorage" + Utils.randomSuffix();
+    private String storage2 = "runPipelineTestStorage" + Utils.randomSuffix();
 
     @AfterClass(alwaysRun = true)
     public void removePipelines() {
@@ -76,7 +81,9 @@ public void removePipelines() {
             .removePipelineIfExists(pipeline303)
             .removePipelineIfExists(pipeline314)
             .removePipelineIfExists(pipeline306)
-            .removePipelineIfExists(pipeline312);
+            .removePipelineIfExists(pipeline312)
+            .removeStorageIfExists(storage1)
+            .removeStorageIfExists(storage2);
     }
 
     @Test
@@ -124,11 +131,19 @@ public void cmdTemplateShouldBeCorrect() {
     @TestCase("EPMCMBIBPC-100")
     public void shouldLaunchPipeline() {
         library()
+            .createStorage(storage1)
+            .createStorage(storage2)
             .createPipeline(Template.PYTHON, pipeline100)
             .clickOnPipeline(pipeline100)
             .firstVersion()
             .runPipeline()
             .setLaunchOptions("20", C.DEFAULT_INSTANCE, "")
+            .selectDataStoragesToLimitMounts()
+            .clearSelection()
+            .searchStorage(storage1)
+            .clearSelection()
+            .searchStorage(storage2)
+            .ok()
             .launch(this)
             .ensure(tabWithName("Active Runs"), visible, selectedTab)
             .ensure(runWithId(getLastRunId()), visible);
@@ -239,6 +254,7 @@ public void runShouldNotAppearInActiveRuns() {
             .clickOnPipeline(pipeline312)
             .firstVersion()
             .runPipeline()
+            .setPriceType(ON_DEMAND)
             .launch(this)
             .showLog(getLastRunId())
             .waitForCompletion();
@@ -253,11 +269,14 @@ public void runShouldNotAppearInActiveRuns() {
     @Test(priority = 2, dependsOnMethods = "runShouldNotAppearInActiveRuns")
     @TestCase({"EPMCMBIBPC-300", "EPMCMBIBPC-267"})
     public void clusterNodePageShouldBeValid() {
-        clusterMenu()
+        ClusterMenuAO clusterMenuAO = clusterMenu()
             .ensure(className("cluster__node-main-info"), visible, have(text("Cluster nodes")))
-            .ensure(button("Refresh"), visible, enabled)
-            .ensureAll(Combiners.select(not(master()), node(), "non-master node"), contains(button("TERMINATE")))
-            .ensureAll(Combiners.select(master(), node(), "master node"), not(contains(button("TERMINATE"))));
+            .ensure(button("Refresh"), visible, enabled);
+        while(clusterMenuAO.nextPageIsExist()) {
+            checkNodes();
+            clusterMenuAO.click(NEXT_PAGE);
+        }
+        checkNodes();
     }
 
     @Test(priority = 2, dependsOnMethods = "runShouldNotAppearInActiveRuns")
@@ -266,6 +285,7 @@ public void nodePageShouldBeValid() {
         final By nonMasterNode = Combiners.select(
                 and("node neither master nor windows", not(master()), not(windows())),
                 node(), "any non-master node");
+        refresh();
         clusterMenu()
             .click(nonMasterNode, NodePage::new)
             .ensure(button("Refresh"), visible, enabled)
@@ -300,4 +320,10 @@ private static Stream<String> prepareExpectedLogMessages(final String pipelineNa
     private static LogAO onRunPage() {
         return new LogAO();
     }
+
+    private void checkNodes() {
+        clusterMenu().context().$$(node()).stream()
+                .forEach(node -> clusterMenu().ensure(node, node.is(master()) ?
+                        not(contains(button("TERMINATE"))) : contains(button("TERMINATE"))));
+    }
 }

e2e/gui/src/test/java/com/epam/pipeline/autotests/RunToolsInSandBoxTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2017-2023 EPAM Systems, Inc. (https://www.epam.com/)
+ * Copyright 2017-2024 EPAM Systems, Inc. (https://www.epam.com/)
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,6 +17,7 @@
 
 import com.epam.pipeline.autotests.ao.LogAO;
 import com.epam.pipeline.autotests.ao.PipelineRunFormAO;
+import static com.epam.pipeline.autotests.ao.Primitive.START_IDLE;
 import com.epam.pipeline.autotests.ao.ToolDescription;
 import com.epam.pipeline.autotests.ao.ToolPageAO;
 import com.epam.pipeline.autotests.mixins.Authorization;
@@ -25,6 +26,7 @@
 import com.epam.pipeline.autotests.utils.TestCase;
 import java.util.function.Function;
 
+import static com.epam.pipeline.autotests.utils.Utils.ON_DEMAND;
 import org.testng.annotations.AfterClass;
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
@@ -211,6 +213,8 @@ public void validationOfDinDLaunchAndFunctionality() {
         tools()
                 .perform(registry, group, tool, runTool())
                 .selectRunCapability("DinD")
+                .click(START_IDLE)
+                .setPriceType(ON_DEMAND)
                 .launch(this)
                 .showLog(getLastRunId())
                 .expandTab(PARAMETERS)
@@ -239,6 +243,8 @@ public void validationOfSingularityLaunchAndFunctionality() {
         tools()
                 .perform(registry, group, tool, runTool())
                 .selectRunCapability("Singularity")
+                .click(START_IDLE)
+                .setPriceType(ON_DEMAND)
                 .launch(this)
                 .showLog(getLastRunId())
                 .expandTab(PARAMETERS)

e2e/gui/src/test/java/com/epam/pipeline/autotests/SamplesMetadataTest.java

@@ -649,7 +649,10 @@ public void setParametersFromMetadataFilesSampleSet() {
                                                 byText(sampleNameAutocomplete))
                                 )
                                 .click(byText(sampleNameAutocomplete), in(comboboxDropdown()))
-                                .click(save())
+                                .sleep(2, SECONDS)
+                                .ensure(SAVE, enabled)
+                                .click(SAVE)
+                                .ensureDisable(SAVE)
                 );
     }
 
@@ -664,7 +667,6 @@ public void validateSampleSetPopup() {
                                         .click(run(), MetadataSelection::new)
                 )
                 .ensure(byText(project), visible)
-                .cd(project)
                 .ensure(byText(metadataFolder), visible)
                 .ensure(MetadataSelection.header, text(project))
                 .ensure(MetadataSelection.folders, text(metadataFolder))

e2e/gui/src/test/java/com/epam/pipeline/autotests/ToolsTest.java

@@ -483,7 +483,7 @@ public void validateEstimatedPriceAvailabilityForFilledTool() {
                 .ensure(PRICE_TABLE, visible)
                 .expandTab(PARAMETERS_PANEL)
                 .clickAddStringParameter()
-                .ensureVisible(PARAMETER_NAME, PARAMETER_VALUE, REMOVE_PARAMETER);
+                .ensureAll(exist, PARAMETER_NAME, PARAMETER_VALUE, REMOVE_PARAMETER);
     }
 
     private By message(final String text) {