-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: add participation viewset #1412
Conversation
8f2f87f
to
aaa65d3
Compare
I think we should keep the other one. The usecase is quite different and it feels weird to include users here as it deals with AbstractParticipations
Both sounds good. |
9e7e3c8
to
ca72d81
Compare
6bfb4a2
to
9037cd3
Compare
9037cd3
to
6221400
Compare
@jeriox should we keep the
users/1/participations
endpoint or deprecate it and include user filtering in this one? It's not trivial, as this new ViewSet works on abstract participations and we'd need a few lines to filter for the Local user participations if a user id to filter for is given.Also, mind that I narrowed the permission check. You now need to be able to view users and the event to see the participations. I'd be fine with only users too, as I find that more important in this case (includes email and stuff). Maybe we should talk about the permission model at some point. For example we could include a reduced view that only shows the VIEW_PUBLIC scoped information like in the web interface (just display name and qualifications, no email).
Todo