feat: add nounset and pipefail bash options (#66)

* feat: add nounset and pipefail options * fix: unbound variable
epiccurious · Dec 18, 2023 · 6a96222 · 6a96222
1 parent b9dc848
commit 6a96222
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 10 deletions.
diff --git a/device_specific/flash_the_m5stack_core_basic b/device_specific/flash_the_m5stack_core_basic
@@ -1,9 +1,11 @@
 #!/bin/bash
-set -e
+set -o errexit
+set -o nounset
+set -o pipefail
 
 cleanup() {
   rm -rf -- "${temp_directory}"
-  if [ -n "${initial_tty_device_permissions}" ] &&
+  if [ -n "${initial_tty_device_permissions:-}" ] &&
     [ "$(stat -c '%a' "${tty_device}")" != "${initial_tty_device_permissions}" ]; then
     sudo chmod "${initial_tty_device_permissions}" "${tty_device}"
   fi

diff --git a/device_specific/flash_the_m5stack_fire b/device_specific/flash_the_m5stack_fire
@@ -1,9 +1,11 @@
 #!/bin/bash
-set -e
+set -o errexit
+set -o nounset
+set -o pipefail
 
 cleanup() {
   rm -rf -- "${temp_directory}"
-  if [ -n "${initial_tty_device_permissions}" ] &&
+  if [ -n "${initial_tty_device_permissions:-}" ] &&
     [ "$(stat -c '%a' "${tty_device}")" != "${initial_tty_device_permissions}" ]; then
     sudo chmod "${initial_tty_device_permissions}" "${tty_device}"
   fi

diff --git a/device_specific/flash_the_m5stack_m5stickc_plus b/device_specific/flash_the_m5stack_m5stickc_plus
@@ -1,9 +1,11 @@
 #!/bin/bash
-set -e
+set -o errexit
+set -o nounset
+set -o pipefail
 
 cleanup() {
   rm -rf -- "${temp_directory}"
-  if [ -n "${initial_tty_device_permissions}" ] &&
+  if [ -n "${initial_tty_device_permissions:-}" ] &&
     [ "$(stat -c '%a' "${tty_device}")" != "${initial_tty_device_permissions}" ]; then
     sudo chmod "${initial_tty_device_permissions}" "${tty_device}"
   fi

diff --git a/device_specific/flash_the_ttgo_tdisplay b/device_specific/flash_the_ttgo_tdisplay
@@ -1,9 +1,11 @@
 #!/bin/bash
-set -e
+set -o errexit
+set -o nounset
+set -o pipefail
 
 cleanup() {
   rm -rf -- "${temp_directory}"
-  if [ -n "${initial_tty_device_permissions}" ] &&
+  if [ -n "${initial_tty_device_permissions:-}" ] &&
     [ "$(stat -c '%a' "${tty_device}")" != "${initial_tty_device_permissions}" ]; then
     sudo chmod "${initial_tty_device_permissions}" "${tty_device}"
   fi

diff --git a/flash_your_device b/flash_your_device
@@ -1,10 +1,12 @@
 #!/bin/bash
-set -e
+set -o errexit
+set -o nounset
+set -o pipefail
 
 cleanup() {
   rm -rf -- "${temp_directory}"
   if [ "${machine}" == "Linux" ] &&
-    [ -n "${initial_tty_device_permissions}" ] &&
+    [ -n "${initial_tty_device_permissions:-}" ] &&
     [ "$(stat -c '%a' "${tty_device}")" != "${initial_tty_device_permissions}" ]; then
     sudo chmod "${initial_tty_device_permissions}" "${tty_device}"
   fi