Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Python 3.7 with 3.12 in test matrix #114

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

qwhelan
Copy link
Contributor

@qwhelan qwhelan commented May 6, 2024

Python 3.7 is deprecated and no longer downloadable via the standard actions setup, so remove and replace with Python 3.12

Documentation test failure appears to be due to Yahoo Finance blocking Github Actions - the failing URL is valid.

@eprbell
Copy link
Owner

eprbell commented May 8, 2024

The URL is actually good, but for some reason some URLs appear broken from Github CI sometimes. The solution is to disable markdown link check: could you enclose the offending link in <!-- markdown-link-check-disable -->...<!-- markdown-link-check-ensable -->?

@qwhelan
Copy link
Contributor Author

qwhelan commented May 8, 2024

@eprbell Done, needs approval from you to run

Copy link
Owner

@eprbell eprbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eprbell eprbell merged commit 5e04d7a into eprbell:main May 9, 2024
19 checks passed
@qwhelan qwhelan deleted the py312 branch May 9, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants