Add Conditional Logic for deploymentAnnotations in Helm Chart #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Description
This pull request introduces changes to the Helm template to implement conditional logic for
deploymentAnnotations
. The update ensures that theannotations:
block is only included in the Kubernetes Deployment manifest ifdeploymentAnnotations
are defined in thevalues.yaml
file.Motivation
The motivation behind this change is to keep the Deployment manifest clean and free from empty or unnecessary annotations when no
deploymentAnnotations
are specified, thereby preventing potential deployment issues and maintaining clarity in the manifest files.Implementation Details
if
statement checks for the presence ofdeploymentAnnotations
in thevalues.yaml
.deploymentAnnotations
exist, the annotations block is added to the Deployment manifest.deploymentAnnotations
, the annotations block is completely omitted, ensuring that only relevant metadata is included in the deployed resources.This approach helps in managing the Deployment's metadata more dynamically based on the configuration provided and avoids cluttering the Kubernetes manifest with empty or irrelevant annotations.
Additional Notes
Please review the changes to ensure that the conditional logic aligns with our deployment standards and let me know if any adjustments are required.