Skip to content

Commit

Permalink
added comments about setting deadlines in generate_task_graph
Browse files Browse the repository at this point in the history
  • Loading branch information
Dhruv Garg committed Nov 28, 2024
1 parent 209a4a3 commit 9104f7e
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions workload/jobs.py
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,9 @@ def _generate_task_graph(
# TODO (Sukrit): Right now, this assumes that all Tasks in the TaskGraph come
# with the same deadline. At some point, we will have to implement a
# heuristic-based deadline splitting technique.

# NOTE: The taskgraph deadline is re-generated (and overwritten) after
# use_branch_predicated_deadlines code, since fuzz is invoked again there.
task_deadline = release_time + self.completion_time.fuzz(
deadline_variance, deadline_bounds
)
Expand Down Expand Up @@ -883,6 +886,8 @@ def _generate_task_graph(
else:
weighted_task_graph_length = self.__get_completion_time()

# NOTE: This is the second time the deadline is being set, based on a second
# invocation of fuzz.
task_graph_deadline = release_time + weighted_task_graph_length.fuzz(
deadline_variance, deadline_bounds
)
Expand Down

0 comments on commit 9104f7e

Please sign in to comment.