-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flow Scheduler #61
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e laid out and can discuss with Alind.
…when instantiating Placement
Closing because too old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement a simplified version of Flow Scheduler presented in Quincy: fair scheduling for distributed computing clusters.
TL;lDR; The major files to review
schedulers/flow_scheduler.py
tests/test_flow_scheduler.py
Changes:
/schedulers
. I was thinking of using git submodules. But since I make some custom patches to the origin repo, git submodule becomes very annoying to deal with. Note I separate the changes that is just copying Flowlessly to this repo in port-flowlessly to keep this PR clean.master
, which no longer exists. Now I have it pull frommain
.schedulers/Flowlessly/src/python/Flowlessly.cpp
usingpybind11
schedulers/flow_scheduler.py
tests/test_flow_scheduler.py
configs/simple_workload_flow.conf
devcontainer
so that people (including myself) using Apple Silicon Mac can run this repo in Github codespace.[cplex](https://pypi.org/project/cplex/)
isn't available on arm 64 architecture.Test Plan
Pass all unit test
Can run flow scheduler against simple_workload
simple_workload_flow.log
: https://gist.github.com/ruizehung/af43e79cbfff7e39f19d416db002761esimple_workload_flow.csv
: https://gist.github.com/ruizehung/725c529232734d88a78f373a9541942cAnd also I'm able to plot based on the output csv. E.g.
There are still some issues with plotting though since we hardcode what
markers
,colors
mapping inanalyze.py
. I think we can fix it when we need it.