Cache And Reuse Solution Values Across Solver Invocations #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al value available
ruizehung
commented
Nov 5, 2023
| @@ -162,6 +162,11 @@ void GurobiSolver::translateModel() { | |||
| TETRISCHED_DEBUG("Adding variable " << variable->getName() << "(" | |||
| << variableId << ") to Gurobi Model."); | |||
| gurobiVariables[variableId] = translateVariable(*gurobiModel, variable); | |||
| // Give the Gurobi variable an initial solution value if it is available. | |||
| if (variable->getInitialValue().has_value()) { | |||
| gurobiVariables[variableId].set(GRB_DoubleAttr_Start, variable->getInitialValue().value()); | |||
There was a problem hiding this comment.
I feel like it would be better if I set start attribute for gurobi variables inside translateVariable? Let me know if you think so and I can change it
There was a problem hiding this comment.
Yep, that would be ideal!
sukritkalra
approved these changes
Nov 6, 2023
| @@ -162,6 +162,11 @@ void GurobiSolver::translateModel() { | |||
| TETRISCHED_DEBUG("Adding variable " << variable->getName() << "(" | |||
| << variableId << ") to Gurobi Model."); | |||
| gurobiVariables[variableId] = translateVariable(*gurobiModel, variable); | |||
| // Give the Gurobi variable an initial solution value if it is available. | |||
| if (variable->getInitialValue().has_value()) { | |||
| gurobiVariables[variableId].set(GRB_DoubleAttr_Start, variable->getInitialValue().value()); | |||
There was a problem hiding this comment.
Yep, that would be ideal!
…obiSolver::translateVariable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces functionality to retain the solution values of variables from the previous invocation of the solver. These values are stored in a cache that persists between solver runs.
When a new variable is added to the solver model, addition logic now checks whether a solution value for a variable with the same name exists in the cache. If a cached value exists, it sets this value as the initial hint for the variable.
Test Plan
Pass unit test
Output for
./test_tetrisched: https://app.warp.dev/block/j3sg3Urzyn1EIfns9CkQsYCan run
python3 main.py --flagfile=configs/new_av_workload.confwith debug enabledThere are too many debug statements being printed and it's hard to capture ones that are relevant to this PR. So I just record a short video instead : )
Screen.Recording.2023-11-05.at.6.15.34.PM.mov