Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zeromq-src to 0.3 #386

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

MarijnS95
Copy link
Contributor

This release includes a fix for cross-compiling, and bumps the ZeroMQ source to v4.3.5.

@domenicquirl
Copy link

Hi, any chance this PR could be revived / merged to bump to zeromq-src v0.3? We're currently having trouble cross-compiling our code due to jean-airoldie/zeromq-src-rs#45, which was fixed with jean-airoldie/zeromq-src-rs#46 / in zeromq-src v0.3.3+4.3.5. Updating to 0.3 would allow consuming this fix (and other ones) through the crates.io release of zmq.

@MarijnS95
Copy link
Contributor Author

@domenicquirl this PR/branch is already based right on top of master, no rebasing or reviving is needed besides merging.

The CI has always been failing on this repository.

@SillyFreak
Copy link

For anyone like me who stumbles upon this PR with cross-compilation struggles: forcing Cargo to use the patched version proposed by this PR worked for me:

[patch.crates-io]
zmq-sys = { git = "https://github.com/MarijnS95/rust-zmq.git", branch = "zeromq-src-0.3" }

It took some time for me to realize that jean-airoldie/zeromq-src-rs#45 -- since that one is fixed -- has the solution, thanks to @domenicquirl for posting it.

(since I'm here, I want to add that I too hope this PR gets merged somewhat soon)

@MarijnS95
Copy link
Contributor Author

Unfortunately I don't have any merge rights nor publish rights to get this trivial yet important upgrade in and published to crates.io. Would be great to have it in, as well as some fixes to a heavily-outdated CI script :)

@Jasper-Bekkers
Copy link
Collaborator

Unfortunately I don't have any merge rights nor publish rights to get this trivial yet important upgrade in and published to crates.io. Would be great to have it in, as well as some fixes to a heavily-outdated CI script :)

I'd love for you to be able to merge this and maintain a bit more of this crate maybe we can ask @erickt to give you access here as well. For now it seems that CI is failing, so I can merge it once that's addressed.

@MarijnS95
Copy link
Contributor Author

Starting to handle CI fixes in #411. We're quite a ways behind but let's tackle it piecemeal :)

This release includes a fix for cross-compiling, and bumps the ZeroMQ
source to v4.3.5.
@MarijnS95
Copy link
Contributor Author

Rebased, let's get this merged and released 👍

@Jasper-Bekkers Jasper-Bekkers merged commit 7ffd6c8 into erickt:master Dec 14, 2024
9 checks passed
@MarijnS95 MarijnS95 deleted the zeromq-src-0.3 branch December 15, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants