-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade zeromq-src
to 0.3
#386
Conversation
Hi, any chance this PR could be revived / merged to bump to |
@domenicquirl this PR/branch is already based right on top of The CI has always been failing on this repository. |
For anyone like me who stumbles upon this PR with cross-compilation struggles: forcing Cargo to use the patched version proposed by this PR worked for me: [patch.crates-io]
zmq-sys = { git = "https://github.com/MarijnS95/rust-zmq.git", branch = "zeromq-src-0.3" } It took some time for me to realize that jean-airoldie/zeromq-src-rs#45 -- since that one is fixed -- has the solution, thanks to @domenicquirl for posting it. (since I'm here, I want to add that I too hope this PR gets merged somewhat soon) |
Unfortunately I don't have any merge rights nor publish rights to get this trivial yet important upgrade in and published to crates.io. Would be great to have it in, as well as some fixes to a heavily-outdated CI script :) |
I'd love for you to be able to merge this and maintain a bit more of this crate maybe we can ask @erickt to give you access here as well. For now it seems that CI is failing, so I can merge it once that's addressed. |
Starting to handle CI fixes in #411. We're quite a ways behind but let's tackle it piecemeal :) |
This release includes a fix for cross-compiling, and bumps the ZeroMQ source to v4.3.5.
1aba88b
to
d96de8f
Compare
Rebased, let's get this merged and released 👍 |
This release includes a fix for cross-compiling, and bumps the ZeroMQ source to v4.3.5.