Add NodeDB metrics for DbSize and DirtySpace #13822
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -750,3 +751,11 @@ func (m *MemoryMutation) HistoryRange(name kv.Domain, fromTs, toTs int, asc orde | |||
| func (m *MemoryMutation) HistoryStartFrom(name kv.Domain) uint64 { | |||
| return m.db.(kv.TemporalTx).HistoryStartFrom(name) | |||
| } | |||
|
|
|||
| func (m *MemoryMutation) EnvInfo() (*mdbxgo.EnvInfo, error) { | |||
There was a problem hiding this comment.
This is leaking abstraction: return underlying data-type. Check - maybe don't need it.
Also i see existing method:
type HasSpaceDirty interface {
SpaceDirty() (uint64, uint64, error)
}
AskAlexSharov
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enable comparison of different SyncPeriod parameters for NodeDB to understand the impact on performance and select the appropriate parameter value. Related task: #13550
The only problem is that I cannot directly use
MdbxKV.CollectMetrics()since that would overwrite the metrics collected from the main MDBX instance.