Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txpool: add more cases to return err instead of panicking on invalid Txn cases #14093

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

somnathb1
Copy link
Contributor

@somnathb1 somnathb1 commented Mar 6, 2025

This pull request includes updates to the DiscardReason function to handle additional discard reasons for transactions. The most important changes include adding new cases for different types of transaction validation errors.

@somnathb1 somnathb1 force-pushed the som/blobhashcheckfail branch from e85c880 to dddc31c Compare March 6, 2025 08:57
@somnathb1 somnathb1 requested review from Giulio2002, yperbasis and shohamc1 and removed request for Giulio2002 March 6, 2025 08:58
Copy link
Member

@yperbasis yperbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also do the same for UnmatchedBlobTxExt plz

Copy link
Member

@yperbasis yperbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also UnequalBlobTxExt

Copy link
Member

@yperbasis yperbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and ErrAuthorityReserved :)

@somnathb1 somnathb1 changed the title txpool: don't panic on BlobHashCheckFail txpool: add more cases to return err instead of panicking on invalid Txn cases Mar 6, 2025
@somnathb1 somnathb1 merged commit 8baa373 into main Mar 6, 2025
12 of 13 checks passed
@somnathb1 somnathb1 deleted the som/blobhashcheckfail branch March 6, 2025 10:16
@yperbasis
Copy link
Member

@somnathb1 plz cherry pick into release/3.0

@yperbasis yperbasis added this to the 3.0.0-rc3 milestone Mar 6, 2025
somnathb1 added a commit that referenced this pull request Mar 6, 2025
…Txn cases (#14093)

This pull request includes updates to the `DiscardReason` function to
handle additional discard reasons for transactions. The most important
changes include adding new cases for different types of transaction
validation errors.
somnathb1 added a commit that referenced this pull request Mar 6, 2025
…Txn cases (#14093)

This pull request includes updates to the `DiscardReason` function to
handle additional discard reasons for transactions. The most important
changes include adding new cases for different types of transaction
validation errors.
Giulio2002 pushed a commit that referenced this pull request Mar 6, 2025
…Txn cases (#14093) (#14096)

…Txn cases (#14093)

This pull request includes updates to the `DiscardReason` function to
handle additional discard reasons for transactions. The most important
changes include adding new cases for different types of transaction
validation errors.

Cherry-Pick #14093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants