Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonrpc: Lenient on param check for eth_getStorageAt #14105

Merged
merged 5 commits into from
Mar 7, 2025
Merged

jsonrpc: Lenient on param check for eth_getStorageAt #14105

merged 5 commits into from
Mar 7, 2025

Conversation

somnathb1
Copy link
Contributor

@somnathb1 somnathb1 commented Mar 7, 2025 •
edited
Loading

I don't think anybody cares about the returned error. Silencing for now, may remove in the future. There was little value in keeping it strict

@somnathb1 somnathb1 changed the title Som/getstorage at lenient jsonrpc: Lenient on param check for eth_getStorageAt Mar 7, 2025
@somnathb1
Copy link
Contributor Author

Hive tests fixed - https://github.com/erigontech/erigon/actions/runs/13716971209/job/38363764893

@somnathb1 somnathb1 enabled auto-merge (squash) March 7, 2025 11:32
@somnathb1 somnathb1 merged commit 96a1353 into main Mar 7, 2025
13 checks passed
@somnathb1 somnathb1 deleted the som/getstorageAtLenient branch March 7, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yperbasis yperbasis yperbasis approved these changes

@Giulio2002 Giulio2002 Awaiting requested review from Giulio2002

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@somnathb1 @yperbasis